refactor: transform useSidebar composable to a pinia store#1897
Merged
JammingBen merged 2 commits intomainfrom Feb 3, 2026
Merged
refactor: transform useSidebar composable to a pinia store#1897JammingBen merged 2 commits intomainfrom
JammingBen merged 2 commits intomainfrom
Conversation
JammingBen
force-pushed
the
refactor/use-sidebar-to-store
branch
3 times, most recently
from
582e679 to
58506ab
Compare
Replaces the `useSideBar` composable with a pinia store. This results in some changes across the code base: * we don't need to pass the sidebar states around since the global store is accessible from everywhere * we don't need to rely on events to toggle the sidebar, hence those have been deprecated in favor of store actions
JammingBen
force-pushed
the
refactor/use-sidebar-to-store
branch
from
58506ab to
091bfd1
Compare
kulmann
approved these changes
Feb 3, 2026
Member
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
Thanks for the cleanup 😍 Also click-tested it and couldn't find anything broken. Nice job!
| sideBarActivePanel.value = panelName | ||
| } | ||
|
|
||
| eventBus.subscribe(SideBarEventTopics.toggle, toggleSideBar) |
Member
There was a problem hiding this comment.
should we be really annoying and wrap the functions into another function which prints a deprecation message to debug output? 🙈
Member
Author
There was a problem hiding this comment.
I don't think we really need to, no? When using the event with SideBarEventTopics like you usually do, you immediately see in your IDE that this is deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
useSideBarcomposable with a pinia store. This results in some changes across the code base:closes #1397