Skip to content

Use ArtifactManager and ChassisManager to replace EntityManager.#325

Merged
Chounoki merged 3 commits into
openconfig:mainfrom
Chounoki:pr1
May 29, 2026
Merged

Use ArtifactManager and ChassisManager to replace EntityManager.#325
Chounoki merged 3 commits into
openconfig:mainfrom
Chounoki:pr1

Conversation

@Chounoki
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Bootz server to replace the EntityManager with separate ArtifactManager and ChassisManager interfaces, introducing an in-memory chassismanager implementation. Additionally, the Sign function in the signature package has been updated to return raw bytes instead of a base64-encoded string.

Critical feedback includes a compilation failure in server/emulator/main.go due to an outdated call to NewServer. Other recommendations focus on preventing nil pointer dereferences by adding nil checks for configurations and mandatory dependencies, handling potential whitespace in certificate serial numbers, and extracting duplicated code for retrieving the server trust anchor certificate into a helper method.

Comment thread server/emulator/main.go Outdated
Comment thread server/server.go
Comment thread server/chassismanager/chassismanager.go
Comment thread server/service/service.go
Comment thread server/service/service.go Outdated
Comment thread server/service/service.go
@Chounoki Chounoki force-pushed the pr1 branch 8 times, most recently from 50d6b23 to 7a3afcc Compare May 27, 2026 08:38
@Chounoki Chounoki requested a review from gmacf May 27, 2026 08:49
@Chounoki Chounoki force-pushed the pr1 branch 2 times, most recently from af368e9 to fd6d323 Compare May 28, 2026 13:40
@Chounoki
Copy link
Copy Markdown
Contributor Author

Thanks for reviewing!

@Chounoki Chounoki merged commit 9cf8ec4 into openconfig:main May 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants