feat: Upgrade social-auth-app-django Dependency#2916
feat: Upgrade social-auth-app-django Dependency#2916deborahgu merged 2 commits intoopenedx:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the version constraint on social-auth-app-django (which was pinned to <=5.4.3 due to test failures), allowing the Credentials service to upgrade to version 5.6.0. The change includes running make upgrade which updates all dependencies to their latest compatible versions.
Key Changes
- Removed the
social-auth-app-django<=5.4.3constraint fromrequirements/constraints.txt - Upgraded
social-auth-app-djangofrom 5.4.3 to 5.6.0 across all requirements files - Added new constraints to
common_constraints.txtfor Django (<6.0) and pip (<25.3) - Updated numerous transitive dependencies as part of the routine upgrade process
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| requirements/constraints.txt | Removed the social-auth-app-django version constraint that was blocking upgrades |
| requirements/common_constraints.txt | Added Django<6.0 constraint and pip<25.3 constraint (pip-tools compatibility issue) |
| requirements/base.txt | Updated social-auth-app-django to 5.6.0 and refreshed all transitive dependencies |
| requirements/test.txt | Updated dependencies including social-auth-app-django and test-related packages |
| requirements/production.txt | Updated dependencies for production environment |
| requirements/dev.txt | Updated dev dependencies including mypy, django-stubs, and django-debug-toolbar |
| requirements/all.txt | Combined updates from all requirement files |
| requirements/translations.txt | Updated Django and related dependencies for translation tools |
| requirements/docs.txt | Updated documentation build dependencies |
| requirements/django.txt | Updated Django version to 5.2.9 |
| requirements/pip_tools.txt | Updated pip-tools to 7.5.2 |
| requirements/pip.txt | Updated pip reference with common_constraints.txt constraint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| requests==2.32.5 | ||
| # via sphinx | ||
| roman-numerals-py==3.1.0 | ||
| roman-numerals==3.1.0 |
There was a problem hiding this comment.
The package name has changed from roman-numerals-py to roman-numerals. This appears to be a package rename in the upgrade. Please verify that this is the correct package name and that it's compatible with the project's usage.
| # -r requirements/dev.txt | ||
| # -r requirements/production.txt | ||
| redis==6.4.0 | ||
| redis==7.1.0 |
There was a problem hiding this comment.
Did you read release notes ?
There was a problem hiding this comment.
no need to upgrade just add constraint for this.
|
not that this will block the ticket either way, but I'm going to do a quick validation of this in 2U's environment. As I recall last time there was an upgrade of this package we had some real pain because they had an incredibly inefficient migration and our (don't consider this a blocker, more in the way of an inform.) |
3 participants
This PR removes the strict version constraint on social-auth-app-django to allow the Credentials service to use newer, supported versions of the package.
Steps taken:
make upgradeto update related dependency entries to ensure compatibility with newer releases.Run JavaScript tests locally with Karma
There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.
make test-karma