feat: General cleanup of legacy Studio page waffle flags and related code#38424
Draft
irfanuddinahmad wants to merge 1 commit intomasterfrom
Draft
feat: General cleanup of legacy Studio page waffle flags and related code#38424irfanuddinahmad wants to merge 1 commit intomasterfrom
irfanuddinahmad wants to merge 1 commit intomasterfrom
Conversation
… code. Remove the waffle flags and helper functions for all legacy Studio pages that have been replaced by the Authoring MFE: - legacy_studio.schedule_details - legacy_studio.advanced_settings - legacy_studio.grading - legacy_studio.import - legacy_studio.export - legacy_studio.course_team - legacy_studio.certificates - legacy_studio.configurations Also removes the course_waffle_flags REST API endpoint (GET /api/contentstore/v1/course_waffle_flags) and its serializer, view, and tests, as these only existed to expose the now-removed flags. Simplifies URL helpers in utils.py to unconditionally return MFE URLs. This work is part of #36108 BREAKING CHANGE: All of the above waffle flags are removed. The GET /api/contentstore/v1/course_waffle_flags endpoint is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the Course Waffle Flags API and its associated serializer, view, tests, and URL routing. This API endpoint previously provided a consolidated way to query the status of various feature toggles (waffle flags) for Studio course pages. The removal also includes cleaning up related imports throughout the codebase. The underlying toggle logic remains intact, so feature flag checks can still be performed directly where needed.
The most important changes are:
Removal of Course Waffle Flags API
CourseWaffleFlagsViewand its serializer (CourseWaffleFlagsSerializer), which provided an endpoint to retrieve the state of various course feature flags. This includes removing the filescourse_waffle_flags.pyfrom bothviewsandserializersdirectories. [1] [2]test_course_waffle_flags.py).course_waffle_flagsfromurls.py, including import statements and URL patterns. [1] [2] [3]Cleanup of Related Imports
__init__.pyfiles and from utility modules. [1] [2] [3]This PR should be merged AFTER merging #38417 #38418 #38419 #38420 #38421 #38422 #38423