Skip to content

Remove replace_v1_lib_refs_with_v2_in_courses dead code - #38951

Merged
salman2013 merged 1 commit into
masterfrom
salman/legacy-code-removal
Aug 6, 2026
Merged

Remove replace_v1_lib_refs_with_v2_in_courses dead code#38951
salman2013 merged 1 commit into
masterfrom
salman/legacy-code-removal

Conversation

@salman2013

@salman2013 salman2013 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes the replace_v1_lib_refs_with_v2_in_courses management command
  • Removes its three associated Celery tasks (validate_all_library_source_blocks_ids_for_course, replace_all_library_source_blocks_ids_for_course, undo_all_library_source_blocks_ids_for_course)

This was dead code from an old, abandoned Blockstore-era V2 library migration approach. As noted in #38230, the actual Ulmo migration intentionally leaves source_library_id as the V1 library ID — only the upstream fields point to V2 blocks. Running this command would have incorrectly mutated source_library_id to a V2 ID.

No tests existed for this command/tasks, and no other code references them.

Ticket: #38244

Remove the `replace_v1_lib_refs_with_v2_in_courses` management command
and its three associated Celery tasks. This was dead code from an old,
abandoned Blockstore-era V2 library migration approach that was never
used in production. The actual Ulmo migration intentionally leaves
`source_library_id` as the V1 library ID; only the `upstream` fields
point to V2 blocks.

Refs: #38230

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Aug 5, 2026
@openedx-webhooks

openedx-webhooks commented Aug 5, 2026

Copy link
Copy Markdown

Thanks for the pull request, @salman2013!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform-oncall.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Aug 5, 2026
@salman2013
salman2013 marked this pull request as draft August 5, 2026 06:23
@salman2013 salman2013 changed the title chore: remove replace_v1_lib_refs_with_v2_in_courses dead code Remove replace_v1_lib_refs_with_v2_in_courses dead code Aug 5, 2026
@salman2013
salman2013 marked this pull request as ready for review August 5, 2026 10:39
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Aug 5, 2026
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Aug 5, 2026

@farhan farhan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@salman2013
salman2013 merged commit 0b2c315 into master Aug 6, 2026
71 of 77 checks passed
@salman2013
salman2013 deleted the salman/legacy-code-removal branch August 6, 2026 12:43
@openedx-webhooks openedx-webhooks removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Aug 6, 2026
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants