Fixed missing videoInput.a in non-standard environments.#554
Fixed missing videoInput.a in non-standard environments.#554GitBruno wants to merge 6 commits intoopenframeworks:bleedingfrom
Conversation
…xt fetch - Use single ofTheo repo - Handle LIBRARY_SUFFIX in msys2 lib copy (libvideoInput*.a glob)
Any fork that has this workflow and pushes to master/bleeding gets its own releases. Which is fine
|
Looks good for ci stuff however the remove of Prepare in videoInput ? |
| # prepare the build environment, executed inside the lib src dir | ||
| function prepare() { | ||
| . "$DOWNLOADER_SCRIPT" | ||
| downloader ${CMAKE_LIST} |
There was a problem hiding this comment.
just confused about this removal was it not needed
There was a problem hiding this comment.
Not needed any longer.
It was used to pull in a CMakeLists.txt from a forked repository. Probably because videoInput did not have this file at the time of code writing, either way for some reason they kept the ofTheo branch and only sourced the CMakeLists.txt from another forked repo. But as this file is now committed in ofTheo's repo so we should not overwrite it with the forked one.
The prepare() function itself is a standard apothecary formula hook, but it is not required for every formula to define it. It will not break because apothecary has a default fallback implementation.
|
Absolutely, thanks! |
3 participants
Fixed missing videoInput.a in certain environments apothecary/formulas/videoInput.sh
Also let's not block running tests on forks ... Other checks are still in place. When we fork we will need to manually activate this anyway. So no incidental builds.
Also tidied
videoInput.shso CMakeLists does not come for a different repository.