Fix of video player path #8150
Merged
Fix of video player path #8150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitre
reviewed
Oct 17, 2024
|
|
||
| //--------------------------------------------------------------------------- | ||
| void ofBaseVideoPlayer::loadAsync(const of::filesystem::path & fileName){ | ||
| loadAsync(fileName.string()); |
Member
There was a problem hiding this comment.
we can use ofPathToString(fileName) here
Contributor
There was a problem hiding this comment.
Indeed. the string() function can throw exceptions and because of that the ofPathToString handles it. In the switch to use fs::path we should enforce the use of ofPathToString rather than calling string() directly.
Member
Author
There was a problem hiding this comment.
ahh good catch! thanks guys!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #8143 this adds the load( std::string ) function to ofBaseVideoPlayer class so that older video players will still work when used with 0.13 and on.
Tested both with using via ofVideoPlayer and directly.
Seems to work great and should allow for both newer path implementation and older legacy approaches.
cc @dimitre @roymacdonald