-
Notifications
You must be signed in to change notification settings - Fork 598
Add chi cross sections to MGXS machinery
#3740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@yardasol, if memory serves, MG transport doesnt use chi, instead it builds
the more accurate nu-fission matrix to determine outgoing fission neutron
energy from an incident neutron. Does this help clarify?
…On Fri, Jan 16, 2026, 12:56 PM Olek ***@***.***> wrote:
@yardasol <https://github.com/yardasol> requested your review on:
openmc-dev/openmc#3740 <#3740>
Add `chi` cross sections to MGXS machinery as a code owner.
—
Reply to this email directly, view it on GitHub
<#3740 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5GMYXIVCF5ZHVA3M5J7L4HEX6RAVCNFSM6AAAAACR6JYOFOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRSGEYDEOJZHE4DQNA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
@nelsonag - the way we have implemented the random ray solver we do currently use Chi (math is here): https://docs.openmc.org/en/latest/methods/random_ray.html#power-iteration Let me know if there's another way of doing this though! @yardasol - we currently use |
|
@jtramm Both |
|
@nelsonag Thanks for that clarification! Do you recall which file this machinery lives in? |
|
Sure, it's in xsdata.cpp, see the XsData::fission_*_from_hdf5 methods.
These load the users input (chi + nu fission no delayed, chi + nu fission
with delayed, nu fission matrix no delayed, etc) and build the chi prompt
and chi delayed matrices accordingly.
If no delayed data is used, then we put the total data within prompt.
No matter what, the output will be a chi matrix and a nu fission vector,
for both prompt (or total) and delayed.
These are then used in Mgxs:: sample_fission_energy to select the outgoing
group based on the incoming group.
I haven't given it much thought yet, but why do you need something
different for random ray?
…On Thu, Jan 22, 2026, 12:12 PM Olek ***@***.***> wrote:
*yardasol* left a comment (openmc-dev/openmc#3740)
<#3740 (comment)>
@nelsonag <https://github.com/nelsonag> Thanks for that clarification! Do
you recall which file this machinery lives in?
—
Reply to this email directly, view it on GitHub
<#3740 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5GM3ZGBJDSFX2LHL2A3D4IEHHLAVCNFSM6AAAAACR6JYOFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOBVHE2DCNRRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@nelsonag Thanks for that explanation! @jtramm My understanding based on |
Description
This PR adds a
chicross section to the existing MGXS machinery. This cross section will be used in the kinetic random ray simulation mode. I have not been able to find anywhere in the MGMC code wherechi_promptorchi_delayedare used, so I have been unable to addchito the MGMC machinery. If anyone knows where in the source code these cross sections are used, that would be helpful. But if they aren't no problem I suppose.Checklist