Do not add radioactive Ta180 when calling add_element('Ta') #3750
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tantalum (Ta) has two naturally occurring isotopes, 180mTa and 181Ta. The ground state 180Ta is actually unstable with a 8 hr half-life. Recently, PR #3443 fixed our natural abundance data to ensure that the metastable state of 180 is given rather than the ground state. Along with that, it added logic for expanding element data to account for whether the nuclear data library has data for the metastable state or not. The problem with the logic is that in the case where no cross sections are available for the metastable, it defaults to adding the (unstable) ground state. In practical terms, this means that when running:
you may get a material that is radioactive. This would happen with ENDF/B-VII.1 and ENDF/B-VIII.0 because they do not have cross sections for the metastable state but do for the ground state. In ENDF/B-VIII.1 cross sections are given for the metastable state so it can be used correctly. However, for the older libraries, the correct thing to do is to simply omit Ta180 and only add Ta181 if the user calls
add_element('Ta').It's important to note that this is not just a hypothetical problem as Ta is included in EUROFER97 reduced-activation steel. Thanks to @jihye4756 for bringing this to my attention!
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)