Recognize meta-annotated test methods in TestsShouldNotBePublic#1040
Merged
Conversation
Resolve #308 so that classes whose methods carry a custom annotation that is itself meta-annotated with @test (e.g. @maventest) also have their redundant public modifier removed. Use AnnotationMatcher's built-in meta-annotation matching rather than hand-rolled recursion.
timtebeek
force-pushed
the
tim/tests-should-not-be-public-meta-annotations
branch
from
c4c836d to
b1936c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestsShouldNotBePublicshould also pick up meta annotations #308.TestsShouldNotBePublicpreviously only matched methods with a direct JUnit 5 annotation (@Test,@BeforeEach, etc.). Methods annotated with a custom annotation that is itself meta-annotated with one of these (e.g. itf's@MavenTest, which is annotated with@TestTemplate/@Test) were not recognized, so the enclosing class kept its redundantpublicmodifier.Change
hasJUnit5MethodAnnotationnow recurses through meta-annotations viaJavaType.FullyQualified#getAnnotations(), with aseenset to guard against annotation cycles.@Test-meta-annotated annotation.