Skip JUnit 4 lifecycle annotation when Jupiter equivalent already present#1043
Merged
Conversation
…sent When a method carries both a JUnit 4 lifecycle annotation (e.g. @before) and its Jupiter equivalent (@beforeeach), changing the type of the JUnit 4 annotation produced a duplicate, non-repeatable annotation. Remove the JUnit 4 annotation instead in that case. Fixes #501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
UpdateBeforeAfterAnnotationsmigrated JUnit 4 lifecycle annotations by changing their type to the Jupiter equivalent. When a method already carried both the JUnit 4 annotation and its Jupiter equivalent — e.g. a shared base class supporting both frameworks:changing
@Beforeto@BeforeEachproduced a duplicate, non-repeatable annotation, yielding the compile error:Now, before the type-change passes run, any JUnit 4 lifecycle annotation whose Jupiter equivalent is already present on the same method is removed instead.