Add CategoryToTag regression test for nested category classes#1045
Closed
timtebeek wants to merge 1 commit into
Closed
Add CategoryToTag regression test for nested category classes#1045timtebeek wants to merge 1 commit into
timtebeek wants to merge 1 commit into
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for
CategoryToTagcovering a@Categoryreferencing a nested class, e.g.@Category(Appenders.Cassandra.class).This is the exact scenario reported in Issue discovered on
log4j-cassandra/src/test/java/org/apache/logging/log4j/cassandra/CassandraAppenderIT.javawithChange type#447, where the recipe threwClassCastException: J$FieldAccess cannot be cast to J$Identifier. The root cause was assumingcategory.getTarget()was always a simpleJ.Identifier, which is not the case forOuter.Inner.classreferences.The underlying bug was already fixed in a692563 (
CategoryToTag: Support qualified class names, which added theconvertToTagNamehelper to handleJ.FieldAccesstargets). However, the existing tests only cover package-qualified names (foo.FastTests.class); none covered the nested-class scenario from Issue discovered onlog4j-cassandra/src/test/java/org/apache/logging/log4j/cassandra/CassandraAppenderIT.javawithChange type#447. This test locks in that behavior so the issue can be closed.Fixes Issue discovered on
log4j-cassandra/src/test/java/org/apache/logging/log4j/cassandra/CassandraAppenderIT.javawithChange type#447