Skip to content

Use EventFactory instead of JacksonEvent.builder() in iceberg-source#6641

Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom
lawofcycles:iceberg-source-use-event-factory
Apr 1, 2026
Merged

Use EventFactory instead of JacksonEvent.builder() in iceberg-source#6641
dlvenable merged 1 commit intoopensearch-project:mainfrom
lawofcycles:iceberg-source-use-event-factory

Conversation

@lawofcycles
Copy link
Copy Markdown
Contributor

Description

Replaces direct usage of JacksonEvent.builder() with EventFactory in the iceberg-source plugin, following the standard Data Prepper pattern used by other source plugins such as FileSource. This is a follow-up to #6554.

Changes:

  • Add EventFactory as a constructor parameter to IcebergSource, IcebergService, ChangelogWorker, and ChangelogRecordConverter
  • Replace JacksonEvent.builder() with eventFactory.eventBuilder(EventBuilder.class) in ChangelogRecordConverter
  • Update unit and integration tests accordingly

Issues Resolved

Related to #6552

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
  • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sotaro Hikita <bering1814@gmail.com>
@lawofcycles
Copy link
Copy Markdown
Contributor Author

I have opened #6682 which adds source-layer shuffle to the iceberg-source plugin. It modifies ChangelogWorker and IcebergService significantly. There are no functional conflicts between the two PRs, but once #6682 is merged, this PR will need a rebase to resolve code-level conflicts in the constructor wiring in IcebergService.

@dlvenable
Copy link
Copy Markdown
Member

@lawofcycles , let's merge this one in and then we can rebase the other.

@dlvenable dlvenable merged commit 5aee2c5 into opensearch-project:main Apr 1, 2026
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants