Fix ShardProfile.fetch typed as single FetchProfile instead of List<FetchProfile>#2040
Open
gingeekrishna wants to merge 2 commits into
Open
Conversation
…etchProfile> OpenSearch returns fetch as a JSON array in profile responses but the spec defined it as a single FetchProfile object. This caused: UnexpectedJsonEventException: Unexpected JSON event 'START_ARRAY' instead of '[START_OBJECT, KEY_NAME]' Change the spec to type: array / items: FetchProfile and update the generated ShardProfile.java to use List<FetchProfile> with array serialization and arrayDeserializer, matching the pattern already used by aggregations and searches in the same class. Fixes opensearch-project#1965 Signed-off-by: Radhakrishnan Pachyappan <gingeekrishna@gmail.com>
gingeekrishna
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
Signed-off-by: Radhakrishnan Pachyappan <gingeekrishna@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1965
OpenSearch returns
fetchas a JSON array in profile responses, but the spec defined it as a singleFetchProfileobject. This caused:Fix: Change the spec to
type: array / items: $ref: FetchProfileand update the generatedShardProfile.javato useList<FetchProfile>with array serialization andarrayDeserializer, matching the pattern already used byaggregationsandsearchesin the same class.