[DNM][testonly][release-v1.21] revert trustbundle propagation in sinkbinding lifecycle Do#1839
Open
maschmid wants to merge 1 commit intoopenshift-knative:release-v1.21from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maschmid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
maschmid
changed the title
Author
|
/hold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testonly, see if we can pass tests without the trustbundle propagation in sinkbinding
DoThe
PropagateTrustBundlesinvocation in Do causes readiness/liveness failured in the eventing-webhook in jobsink scenarios, as it gets/updates trustbundle CMs per each resource bound by sinkbinding (which, for use cases such as sinkbinding-bound jobsink jobs is a lot of resources... )(the trustbundle propagation in Do was introduced in knative@f88d983 )