Skip to content

[release-v1.21] SRVKE-1833: Remove unnecessary conversion webhook from RequestReply CRD#1869

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift-knative:release-v1.21from
creydr:cp-requestreply-webhook-fix-v1.21
Apr 23, 2026
Merged

[release-v1.21] SRVKE-1833: Remove unnecessary conversion webhook from RequestReply CRD#1869
openshift-merge-bot[bot] merged 2 commits intoopenshift-knative:release-v1.21from
creydr:cp-requestreply-webhook-fix-v1.21

Conversation

@creydr
Copy link
Copy Markdown
Collaborator

@creydr creydr commented Apr 23, 2026

Backport of knative@152cef3

creydr added 2 commits April 23, 2026 11:39
…9039)

RequestReply only has a single version (v1alpha1) and was never
registered in the conversion controller, so the webhook's CA bundle
was never injected. This caused kube-apiserver to log x509 certificate
errors when trying to reach the unconfigured webhook endpoint.
@openshift-ci-robot
Copy link
Copy Markdown

@creydr: This pull request references SRVKE-1833 which is a valid jira issue.

Details

In response to this:

Backport of knative@152cef3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from Cali0707 and lberk April 23, 2026 09:46
@creydr
Copy link
Copy Markdown
Collaborator Author

creydr commented Apr 23, 2026

/cc @maschmid

@openshift-ci openshift-ci Bot requested a review from maschmid April 23, 2026 09:47
@maschmid
Copy link
Copy Markdown

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 796a7bc into openshift-knative:release-v1.21 Apr 23, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants