Skip to content

Fix IPv6 VIPs DNS lookup for baremetal deployments#1814

Open
mnietoji wants to merge 1 commit into
openshift-metal3:masterfrom
mnietoji:ipv6_dnslookup
Open

Fix IPv6 VIPs DNS lookup for baremetal deployments#1814
mnietoji wants to merge 1 commit into
openshift-metal3:masterfrom
mnietoji:ipv6_dnslookup

Conversation

@mnietoji

Copy link
Copy Markdown

Issue when using Dual stack networking as EXTERNAL_SUBNET_V4 is defined. Instead, use IP_STACK for setting API_VIPS and INGRESS_VIPS for either IPV4, IPV6 or Dual stack

@openshift-ci openshift-ci Bot requested review from celebdor and zaneb November 21, 2025 10:11
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 21, 2025
@openshift-ci

openshift-ci Bot commented Nov 21, 2025

Copy link
Copy Markdown

Hi @mnietoji. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dtantsur

dtantsur commented Dec 1, 2025

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2025
@cybertron

Copy link
Copy Markdown
Contributor

/test e2e-metal-ipi-bm

Failed on an infra issue before it started testing the patch, seems like we should make sure it passes this job though.

Issue when using Dual stack networking as EXTERNAL_SUBNET_V4 is defined.
Instead, use IP_STACK for setting API_VIPS and INGRESS_VIPS for either
IPV4, IPV6 or Dual stack
@mnietoji

Copy link
Copy Markdown
Author

/retest

@cybertron

Copy link
Copy Markdown
Contributor

/lgtm

Looks reasonable to me and passed the bm jobs.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2026
@mnietoji

mnietoji commented Jan 9, 2026

Copy link
Copy Markdown
Author

/retest-required

@mnietoji

Copy link
Copy Markdown
Author

hi, what else is needed to merge this PR?

@cybertron

Copy link
Copy Markdown
Contributor

/assign @elfosardo

@mkowalski

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Apr 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@openshift-ci

openshift-ci Bot commented Apr 30, 2026

Copy link
Copy Markdown

@mnietoji: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 4d79122 link false /test e2e-agent-compact-ipv4-iso-no-registry
ci/prow/e2e-metal-ipi-serial-ipv4-1of2 4d79122 link unknown /test e2e-metal-ipi-serial-ipv4-1of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants