METAL-1863: Convert install-config generation from bash heredoc to Ansible#1911
Open
elfosardo wants to merge 1 commit into
Open
METAL-1863: Convert install-config generation from bash heredoc to Ansible#1911elfosardo wants to merge 1 commit into
elfosardo wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
elfosardo
force-pushed
the
ansible-install-config
branch
2 times, most recently
from
92d1156 to
ca9ac1f
Compare
Member
Author
|
/retest |
5 similar comments
Member
Author
|
/retest |
Member
Author
|
/retest |
Member
Author
|
/retest |
Member
Author
|
/retest |
Member
Author
|
/retest |
elfosardo
force-pushed
the
ansible-install-config
branch
2 times, most recently
from
5d75750 to
3443cc4
Compare
Member
Author
|
/retest |
elfosardo
force-pushed
the
ansible-install-config
branch
3 times, most recently
from
3814173 to
afc69b4
Compare
Replace the generate_ocp_install_config() bash heredoc in ocp_install_env.sh with an Ansible role and Jinja2 template. 05_create_install_config.sh now sources the existing config chain for environment variable resolution, generates YAML extra-vars via a config bridge script, and calls ansible-playbook to render install-config.yaml. This is the first step toward migrating dev-scripts from imperative bash to declarative Ansible roles. The extra worker manifest generation remains in bash for now. Assisted-By: Claude Opus 4.6
elfosardo
force-pushed
the
ansible-install-config
branch
from
afc69b4 to
5cbf0dc
Compare
|
@elfosardo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the generate_ocp_install_config() bash heredoc in ocp_install_env.sh with an Ansible role and Jinja2 template.
05_create_install_config.sh now sources the existing config chain for environment variable resolution, generates YAML extra-vars via a config bridge script, and calls ansible-playbook to render install-config.yaml.
This is the first step toward migrating dev-scripts from imperative bash to declarative Ansible roles. The extra worker manifest generation remains in bash for now.
Assisted-By: Claude Opus 4.6