OPRUN-4466: Add NewOLMConfigAPI feature gate#2710
OPRUN-4466: Add NewOLMConfigAPI feature gate#2710anik120 wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@anik120: This pull request references OPRUN-4466 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @anik120! Some important instructions when contributing to openshift/api: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughA new feature gate named NewOLMConfigAPI was introduced across the codebase. The feature gate is declared in features.go with configuration specifying the OLM Jira component, contact person, OpenShift-specific product scope, and an enhancement PR reference. It is enabled for SelfManaged cluster profiles with DevPreviewNoUpgrade and TechPreviewNoUpgrade statuses. Documentation was updated in features.md. Multiple feature gate manifest files were updated to reflect the new gate, with its status (enabled or disabled) varying by deployment profile and cluster type in the payload manifests. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.5.0)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Review Summary by QodoAdd NewOLMConfigAPI feature gate for OLM configuration API
WalkthroughsDescription• Add NewOLMConfigAPI feature gate definition with OLM component scope • Enable feature for SelfManaged and preview cluster profiles • Update feature gate documentation and manifest files • Register feature gate across all Hypershift and SelfManagedHA profiles Diagramflowchart LR
A["NewOLMConfigAPI Feature Gate"] -->|defined in| B["features.go"]
A -->|documented in| C["features.md"]
A -->|enabled in| D["Hypershift Profiles"]
A -->|enabled in| E["SelfManagedHA Profiles"]
D -->|includes| F["Default/DevPreview/TechPreview/OKD"]
E -->|includes| G["Default/DevPreview/TechPreview/OKD"]
File Changes1. features/features.go
|
|
@anik120: This pull request references OPRUN-4466 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
| reportProblemsToJiraComponent("olm"). | ||
| contactPerson("anik120"). | ||
| productScope(ocpSpecific). | ||
| enhancementPR("https://github.com/openshift/enhancements/pull/1915"). |
There was a problem hiding this comment.
Can we add this initially as DevPreview? We are expecting that tech preview gated features have a merged EP containing the basics for getting the feature to TP, but I see the EP is currently in draft
There was a problem hiding this comment.
@JoelSpeed actually we've moved that EP out of draft and it's ready for review :) I'm hoping there's enough time for us to get the EP merged and land this in TP in 4.22 (the usual process we've followed for far for all OLMv1 features).
It also doesn't change the API surface for any CRD and doesn't affect any other OCP components, so my guess is the review should not take too long.
openshift-merge-robot
added
the
needs-rebase
anik120
force-pushed
the
olmv1-broader-feature-gate
branch
from
db623d7 to
4ace895
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@anik120: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
EP: openshift/enhancements#1915