Skip to content

[release-4:17] OCPBUGS-85244: whereabouts-token-watcher DaemonSet improvements#3016

Open
bpickard22 wants to merge 1 commit into
openshift:release-4.17from
bpickard22:4.17-token-watcher-backport
Open

[release-4:17] OCPBUGS-85244: whereabouts-token-watcher DaemonSet improvements#3016
bpickard22 wants to merge 1 commit into
openshift:release-4.17from
bpickard22:4.17-token-watcher-backport

Conversation

@bpickard22
Copy link
Copy Markdown
Contributor

Manual backport of #2850 due to small conflict in the mountpath (we needed to fix this anyway)

(cherry picked from commit 1e4bacb)

This commit introduces several improvements to the whereabouts-token-watcher DaemonSet:
- Corrects a typo in the description.
- Adds logging helper functions for better script output.
- Ensures the service account token is read dynamically during kubeconfig generation.
- Fixes the logical grouping in the CA file change detection condition.
- Increases the kubeconfig regeneration check interval to 60 seconds.
- Mounts the host's CNI network directory for proper CNI configuration management.

Signed-off-by: Peng Liu <pliu@redhat.com>
(cherry picked from commit 1e4bacb)
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b70c6cad-d74b-4b38-82a3-a846b2ad90a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bpickard22 bpickard22 changed the title Fix: whereabouts-token-watcher DaemonSet improvements [release-4:17] OCPBUGS-85244: whereabouts-token-watcher DaemonSet improvements May 29, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 29, 2026

@bpickard22: This pull request references release-4 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.z" version, but no target version was set.

Details

In response to this:

Manual backport of #2850 due to small conflict in the mountpath (we needed to fix this anyway)

(cherry picked from commit 1e4bacb)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from pperiyasamy and tssurya May 29, 2026 14:22
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bpickard22
Once this PR has been reviewed and has the lgtm label, please assign tssurya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bpickard22
Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@bpickard22
Copy link
Copy Markdown
Contributor Author

/retest-required

@bpickard22
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@bpickard22
Copy link
Copy Markdown
Contributor Author

/retest

@bpickard22
Copy link
Copy Markdown
Contributor Author

hypershift conformance lane is permafailing on a provisioning timeout - this is unrelated to the changes in this pr

@bpickard22
Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

@bpickard22: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 92c457e link false /test security
ci/prow/e2e-aws-ovn-hypershift-conformance 92c457e link true /test e2e-aws-ovn-hypershift-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants