HPCASE-208:Add TLSAdherencePolicy helper#2114
HPCASE-208:Add TLSAdherencePolicy helper#2114richardsonnick wants to merge 3 commits intoopenshift:masterfrom
Conversation
This helper gives us control on the behavior of consuming components without making changes to the APIServer CRD.
|
Skipping CI for Draft Pull Request. |
|
This will be a draft diff until openshift/api#2680 is landed. Since 2680 adds the TLSAdherencePolicy type |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: richardsonnick The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@richardsonnick: This pull request references HPCASE-208 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@richardsonnick: This pull request references HPCASE-208 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@richardsonnick: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
|
Tests will not pass until api changes are merged: openshift/api#2680 |
Add ShouldHonorClusterTLSProfile helper for TLS adherence policy
Adds a helper function that encapsulates the logic for determining
whether a component should honor the cluster-wide TLS security profile
from apiserver.config.openshift.io/cluster.
This function handles:
Component implementors should use this helper rather than checking
tlsAdherence field values directly, allowing coordinated changes to
the default semantic across all implementations.
See: https://github.com/openshift/enhancements/pull/XXXX
Relevant APIServer changes: openshift/api#2680