Fix Slack channel to use saas configured channel#3148
Fix Slack channel to use saas configured channel#3148YiqinZhang wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
There are test jobs defined for this repository which are not configured to run automatically. Comment |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YiqinZhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5bc83d3 to
69ebda8
Compare
69ebda8 to
cf88553
Compare
|
/pipeline required |
|
Scheduling required tests: |
|
@YiqinZhang: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes Slack notifications going to the default channel instead of the team configured one.
sendFailureNotificationnow falls back toSLACK_CHANNELwhenLOG_ANALYSIS_SLACK_CHANNELis unset, so each SaaS target can control its notification channel via the existingSLACK_CHANNELparameter.SDCICD-1758