Skip to content

Fix Slack channel to use saas configured channel#3148

Open
YiqinZhang wants to merge 1 commit intoopenshift:mainfrom
YiqinZhang:slack-channel
Open

Fix Slack channel to use saas configured channel#3148
YiqinZhang wants to merge 1 commit intoopenshift:mainfrom
YiqinZhang:slack-channel

Conversation

@YiqinZhang
Copy link
Contributor

@YiqinZhang YiqinZhang commented Mar 11, 2026

Fixes Slack notifications going to the default channel instead of the team configured one. sendFailureNotification now falls back to SLACK_CHANNEL when LOG_ANALYSIS_SLACK_CHANNEL is unset, so each SaaS target can control its notification channel via the existing SLACK_CHANNEL parameter.

SDCICD-1758

@openshift-ci-robot
Copy link

There are test jobs defined for this repository which are not configured to run automatically. Comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger jobs most likely to be impacted by the proposed changes.Comment /pipeline required to trigger all required & necessary jobs.

@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: fff6abcf-90cd-4369-a492-8e23d2bd2614

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YiqinZhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2026
@YiqinZhang YiqinZhang changed the title read slack para first Fix Slack channel to use configured parameter Mar 11, 2026
@YiqinZhang YiqinZhang changed the title Fix Slack channel to use configured parameter Fix Slack channel to use test yaml configured channel Mar 11, 2026
@YiqinZhang YiqinZhang changed the title Fix Slack channel to use test yaml configured channel Fix Slack channel to use saas configured channel Mar 11, 2026
@YiqinZhang
Copy link
Contributor Author

/pipeline required

@openshift-ci-robot
Copy link

Scheduling required tests:
/test hypershift-pr-check

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2026

@YiqinZhang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-pr-check cf88553 link true /test hypershift-pr-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants