Skip to content

NO-JIRA: Update the installer golangci-lint to v2.8#75091

Open
vimauro wants to merge 3 commits intoopenshift:mainfrom
vimauro:users/vimauro/upgrade_golangci
Open

NO-JIRA: Update the installer golangci-lint to v2.8#75091
vimauro wants to merge 3 commits intoopenshift:mainfrom
vimauro:users/vimauro/upgrade_golangci

Conversation

@vimauro
Copy link

@vimauro vimauro commented Feb 19, 2026

Update the installer golangci-lint to v2.8 (built on GO 1.25)

Related to openshift/installer#10320 where I am upgrading the installer dependencies to GO 1.25

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2026
@openshift-ci-robot
Copy link
Contributor

@vimauro: This pull request explicitly references no jira issue.

Details

In response to this:

Update the installer golangci-lint to v2.8 (built on GO 1.25)

Related to openshift/installer#10320 where I am upgrading the installer dependencies to GO 1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vimauro
Copy link
Author

vimauro commented Feb 19, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@vimauro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vimauro
Copy link
Author

vimauro commented Feb 19, 2026

/test ci-operator-config

@eggfoobar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2026
@eggfoobar
Copy link
Contributor

Actually, can you also update 4.22 and 4.23 files as well, since the bump will effect those lanes as well

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2026
@vimauro
Copy link
Author

vimauro commented Feb 19, 2026

Actually, can you also update 4.22 and 4.23 files as well, since the bump will effect those lanes as well

Done, thanks!

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@vimauro: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-release-4.23-artifacts-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-aws-private openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-azure-ovn-marketplace-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-azure-private openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-4control-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-5control-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-compact-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-compact-ipv4-appliance-diskimage openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-compact-ipv4-iso-no-registry openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-compact-ipv4-none-platform openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-compact-ipv6-minimaliso openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-ha-dualstack openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-sno-ipv4-pxe openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-sno-ipv6 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-byo-subnet-role-security-groups openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-custom-dns-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-default-config openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-overlay-mtu-ovn-1200 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-custom-iam-profile openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-dualstack-ipv4-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-edge-zones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-edge-zones-manifest-validation openshift/installer presubmit Ci-operator config changed

A total of 353 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@vimauro
Copy link
Author

vimauro commented Feb 19, 2026

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@vimauro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@vimauro: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-release-4.23-artifacts-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-aws-private openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-azure-ovn-marketplace-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-azure-private openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-4control-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-5control-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-compact-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-compact-ipv4-appliance-diskimage openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-compact-ipv4-iso-no-registry openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-compact-ipv4-none-platform openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-compact-ipv6-minimaliso openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-ha-dualstack openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-sno-ipv4-pxe openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-sno-ipv6 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-byo-subnet-role-security-groups openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-custom-dns-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-default-config openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-overlay-mtu-ovn-1200 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-custom-iam-profile openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-dualstack-ipv4-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-edge-zones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-edge-zones-manifest-validation openshift/installer presubmit Ci-operator config changed

A total of 470 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@eggfoobar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eggfoobar, vimauro
Once this PR has been reviewed and has the lgtm label, please assign sdodson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments