feat(rhdh): skip gather chain on successful PR runs via allow_skip_on_success

[gustavolira]

Summary

• Add allow_skip_on_success: true to the RHDH e2e-ocp-helm PR test steps
• The chain: gather refs already have optional_on_success: true, so this flag enables ci-operator to skip them automatically when tests pass
• Expected savings: ~8 minutes on successful PR runs (gather-extra ~6m + must-gather ~1m43s)

Changes

1-line config change: allow_skip_on_success: true added to the e2e-ocp-helm test steps.

On test failure, the full gather chain continues to run as before.

Test plan

• Rehearse job passes
• Successful PR run skips gather chain (post-phase < 1 min)
• Failed PR run still collects full gather artifacts

Related

• Companion PR (RHDH repo): feat(ci): skip pod log collection on success, write TESTS_PASSED marker redhat-developer/rhdh#4267
• Jira: RHIDP-12291

🤖 Generated with Claude Code

[subhashkhileri]

refs in chain: gather have optional_on_success: true which means we can use allow_skip_on_success flag and it should skip this automatically
they just weren't being skipped because the test config is missing allow_skip_on_success: true, could you try this flag and see if it works in rehearse?

Suggested change

	- ref: redhat-developer-rhdh-gather
	allow_skip_on_success: true
	post:
	- ref: redhat-developer-rhdh-send-data-router
	- chain: gather

[gustavolira]

Great catch! You're absolutely right — allow_skip_on_success: true is much simpler since the gather chain refs already have optional_on_success: true. I've simplified the PR to just add that single flag. Removed the custom gather step entirely.

The PR is now a 1-line change. Let's see how rehearse goes.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gustavolira
Once this PR has been reviewed and has the lgtm label, please assign christoph-jerolimov for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/redhat-developer/rhdh/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@gustavolira: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-redhat-developer-rhdh-main-e2e-ocp-helm	redhat-developer/rhdh	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@gustavolira: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.