Skip to content

[WIP] OCPBUGS-86840: Update the gatewayapi conformance tests to run with gatewayAPI changes#80127

Open
rhamini3 wants to merge 1 commit into
openshift:mainfrom
rhamini3:master
Open

[WIP] OCPBUGS-86840: Update the gatewayapi conformance tests to run with gatewayAPI changes#80127
rhamini3 wants to merge 1 commit into
openshift:mainfrom
rhamini3:master

Conversation

@rhamini3
Copy link
Copy Markdown
Contributor

@rhamini3 rhamini3 commented Jun 4, 2026

adding a rule to the gatewayAPI conformance tests to run automatically with any gatewayAPI changes, script updates, controller updates, and e2e test updates

Summary by CodeRabbit

  • Chores
    • Updated CI configuration to optimize test execution by running gateway API conformance tests only when relevant code is modified.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamini3: This pull request references Jira Issue OCPBUGS-86840, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

adding a rule to the gatewayAPI conformance tests to run automatically with any gatewayAPI changes, script updates, controller updates, and e2e test updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from candita and jcmoraisjr June 4, 2026 22:10
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Walkthrough

A single line is added to the cluster-ingress-operator CI configuration, introducing a run_if_changed trigger pattern to the e2e-aws-gatewayapi-conformance job. The pattern constrains job execution to changes affecting gateway-api manifests, ingress-operator code, build scripts, gatewayapi controller code, or e2e tests.

Changes

Gateway API Conformance Job CI Trigger

Layer / File(s) Summary
Job execution trigger configuration
ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master.yaml
The e2e-aws-gatewayapi-conformance job adds a run_if_changed regex selector matching gateway-api manifests, operator commands, scripts, gatewayapi controller, and e2e test paths.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo test definitions - only modified CI configuration and utility test files unrelated to Ginkgo e2e tests.
Test Structure And Quality ✅ Passed The PR only modifies CI configuration files and related infrastructure (YAML, tools, docs). No Ginkgo test code is modified, making the check inapplicable to this PR.
Microshift Test Compatibility ✅ Passed PR only modifies CI configuration YAML to add a run_if_changed trigger; no new Ginkgo e2e tests are added or modified, so no MicroShift compatibility check is applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only CI config file to add run_if_changed pattern. No new Ginkgo e2e tests added; repository contains CI metadata, not test source code.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI operator configuration, adding a run_if_changed trigger to a test job. No deployment manifests, operator code, controllers, or scheduling constraints are modified.
Ote Binary Stdout Contract ✅ Passed PR modifies only CI config (YAML), not test/binary source code. OTE Binary Stdout Contract check applies to process-level code violations, which are absent here.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added. PR only modifies CI job configuration (YAML) to add a run_if_changed trigger; the check does not apply.
No-Weak-Crypto ✅ Passed PR contains only CI configuration changes to a YAML file with no cryptographic code, weak crypto algorithms, custom implementations, or token comparisons.
Container-Privileges ✅ Passed PR modifies only CI operator configuration file. No container privilege settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation) found in the changed file.
No-Sensitive-Data-In-Logs ✅ Passed PR adds only a CI trigger pattern (run_if_changed) with regex file paths—no logging statements or sensitive data exposure to passwords, tokens, API keys, PII, or other protected information.
Title check ✅ Passed The PR title clearly describes the main change: updating gatewayapi conformance tests to run conditionally with gatewayAPI changes. This aligns with the run_if_changed trigger pattern added to the CI configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhamini3
Once this PR has been reviewed and has the lgtm label, please assign davidesalerno for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamini3 rhamini3 changed the title OCPBUGS-86840: Update the gatewayapi conformance tests to run with gatewayAPI changes [WIP] OCPBUGS-86840: Update the gatewayapi conformance tests to run with gatewayAPI changes Jun 4, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rhamini3: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-gatewayapi-conformance openshift/cluster-ingress-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

@rhamini3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config 014e8ad link true /test generated-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants