AUTOSCALE-681: update aws-karpenter-provider-aws configs#80128
Conversation
Signed-off-by: Max Cao <macao@redhat.com>
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@maxcao13: This pull request references AUTOSCALE-681 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (9)
💤 Files with no reviewable changes (7)
WalkthroughThis PR updates the AWS Karpenter provider CI configurations by introducing multi-arch release candidates (multi-initial and multi-latest) for main and 4.22 branches while systematically removing hypershift test support from all periodic and stable release configurations (4.19–5.0). ChangesAWS Karpenter Provider CI Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-aws-karpenter-provider-aws-main-e2e-hypershift pull-ci-openshift-aws-karpenter-provider-aws-release-4.22-e2e-hypershift |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
@maxcao13: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
i'm not 100% sure on the environment variable additions, but the periodic removals look ok to me.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No, it's related to one of the bug that john merged openshift/hypershift#8562 but hasn't backported to 4.22 yet: openshift/hypershift#8632 We saw this failure in this other hypershift release config fixup PR here: #79262 |
3 participants
Removes hypershift periodics in aws-karpenter-provider-aws. New periodics which cover the same code paths have been added to the hypershift repo for 4.22 and 5.0 here: #79262
Also updates the presubmits to match the new TestKarpenterUpgradeControlePlane suite, and allow them to run as multi-arch.
Summary by CodeRabbit
This PR updates the CI configuration for the AWS Karpenter Provider AWS repository, consolidating hypershift test coverage and enabling multi-architecture testing support.
Key Changes:
Removes hypershift periodics: The
e2e-hypershiftperiodic test entries and their associated hypershift base image references have been removed from release branch configurations (4.19–5.0 periodics). These tests are being consolidated into the hypershift repository's CI pipeline instead, as noted in PR#79262.Adds multi-architecture support: Both the main branch and release 4.22 configurations now define multi-arch release candidates (
multi-initialandmulti-latest) targeting themultiarchitecture with OCP nightly builds. This enables CI to test karpenter functionality across multiple architectures.Updates test configuration for multi-arch: The
e2e-hypershifttest configuration in the main and release-4.22 branches now:OCP_IMAGE_LATESTandOCP_IMAGE_PREVIOUSmappingsAWS_MULTI_ARCH: "true"environment variable to enable multi-arch testingCI_TESTS_RUNfilter to^TestKarpenter(matching the new test suite naming)Configuration cleanup: Release-4.21 adds a
verify-depstest step withgo-verify-depsto replace the removed hypershift tests.Practical impact: The AWS Karpenter Provider AWS repository's CI pipeline now focuses on testing karpenter-specific functionality in multi-arch environments, while hypershift integration tests are maintained separately in the hypershift repository for better organizational clarity.