NO-JIRA: Enable Gateway API vsphere with metallb on 4.21

[rikatz]

Enable Gateway API test on vsphere with 4.21 during presubmit for this branch

Summary by CodeRabbit

This PR adds a new optional e2e test to the OpenShift cluster-ingress-operator CI configuration for the 4.21 release. Specifically, it enables the Gateway API test on vSphere infrastructure with MetalLB load balancing.

The change adds a new test step (e2e-vsphere-static-metallb-operator-gwapi) to the presubmit CI pipeline that:

• Runs the Gateway API test suite (make TEST=TestGatewayAPI test-e2e) on the vSphere elastic cluster profile
• Uses the MetalLB static IP allocation workflow (ingress-vsphere-static-metallb)
• Allocates 100m of CPU resources
• Runs as an optional test (does not block PR merging if it fails)
• Skips execution when only documentation or metadata files are changed

This expands test coverage for the cluster ingress operator by validating Gateway API functionality on vSphere with MetalLB, complementing existing tests on AWS, GCP, and other platforms.

[openshift-ci-robot]

@rikatz: This pull request references Jira Issue OCPBUGS-85149, which is invalid:

• expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.21.z" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Enable Gateway API test on vsphere with 4.21 during presubmit for this branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rikatz: This pull request explicitly references no jira issue.

Details

In response to this:

Enable Gateway API test on vsphere with 4.21 during presubmit for this branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f331ad02-b4cc-436c-bf27-783bffb2cf2f

📥 Commits

Reviewing files that changed from the base of the PR and between dd3b7e2 and 78eb1b7.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-release-4.21-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-release-4.21.yaml

---

Walkthrough

A single e2e test step for Gateway API is added to the cluster ingress operator release-4.21 CI configuration. The new test runs the TestGatewayAPI suite on a vSphere elastic cluster with MetalLB operator and skips execution when only documentation or metadata files change.

Changes

CI Test Configuration

Layer / File(s)	Summary
Gateway API vSphere test step ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-release-4.21.yaml	New optional e2e test e2e-vsphere-static-metallb-operator-gwapi added to run Gateway API tests on vSphere with MetalLB, configured with vsphere-elastic cluster profile, 100m CPU request, and skip conditions for documentation changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: enabling a Gateway API test on vSphere with MetalLB for OpenShift 4.21, which directly matches the added e2e test step in the configuration file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR adds only CI configuration (YAML), not Ginkgo test code. No test name declarations (It(), Describe(), etc.) are modified or added.
Test Structure And Quality	✅ Passed	The PR modifies only CI configuration (YAML) to add a test job reference, not Ginkgo test code. The custom check for Ginkgo test quality is not applicable to CI configuration files.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e test code added in this PR—only a CI configuration change referencing a test in cluster-ingress-operator repository; check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only adds CI configuration entries in the release repository, not new Ginkgo e2e tests. The actual test code lives separately in cluster-ingress-operator.
Topology-Aware Scheduling Compatibility	✅ Passed	CI configuration file change adding a test step. No deployment manifests, operator code, or scheduling constraints (affinity, topology spread, node selectors, PDBs) are present.
Ote Binary Stdout Contract	✅ Passed	PR modifies only CI YAML configuration, not test code. OTE Binary Stdout Contract check applies to Go test code, which is absent here.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds only CI configuration; no new Ginkgo e2e test code is added. The check applies to test code additions, not CI config enabling existing tests.
No-Weak-Crypto	✅ Passed	PR adds only a CI/CD test configuration to a YAML file. No cryptographic algorithms, custom crypto implementations, or non-constant-time comparisons are present.
Container-Privileges	✅ Passed	No privileged container settings found. PR adds CI pipeline config with only test step definition, no privilege-escalation or security context fields.
No-Sensitive-Data-In-Logs	✅ Passed	The new test configuration contains no sensitive data logging: no environment variables, no credentials section, no secret mounting, and no shell commands exposing tokens, passwords, or API keys.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@rikatz: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-vsphere-static-metallb-operator-gwapi	openshift/cluster-ingress-operator	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[rikatz]

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-vsphere-static-metallb-operator-gwapi

[openshift-merge-bot]

@rikatz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@rikatz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gcs278]

/assign

[gcs278]

Pretty straightforward PR to add a new vsphere pre-submit job for 4.21. Note that it is always off, so I doubt it will run much, if at all. I suppose we should try to trigger it when we can remember on some 4.21 backport PRs.

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cluster-ingress-operator/OWNERS [gcs278,rikatz]
• ci-operator/jobs/openshift/cluster-ingress-operator/OWNERS [gcs278,rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment