Skip to content

OLS-3218 - Remove integration tests agentic ols#80158

Open
JoaoFula wants to merge 2 commits into
openshift:mainfrom
JoaoFula:remove-integration-tests-agentic-ols
Open

OLS-3218 - Remove integration tests agentic ols#80158
JoaoFula wants to merge 2 commits into
openshift:mainfrom
JoaoFula:remove-integration-tests-agentic-ols

Conversation

@JoaoFula
Copy link
Copy Markdown
Contributor

@JoaoFula JoaoFula commented Jun 5, 2026

removing the integration tests in agentic ols since we're moving them to konflux
openshift/lightspeed-agentic-sandbox#70

JoaoFula added 2 commits June 5, 2026 16:18
E2e tests for claude, gemini, and openai are now Konflux integration
tests defined in the sandbox repo. Remove the Prow e2e-claude,
e2e-gemini, e2e-openai test blocks, the e2e-podman image, and the
nested-podman base image. Lint and unit-test remain.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoaoFula
Once this PR has been reviewed and has the lgtm label, please assign blublinsky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from harche and xrajesh June 5, 2026 14:57
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7da74dc7-bf12-4c8b-84f3-a92052edca44

📥 Commits

Reviewing files that changed from the base of the PR and between 95435cc and 58a835a.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/lightspeed-agentic-sandbox/openshift-lightspeed-agentic-sandbox-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/lightspeed-agentic-sandbox/openshift-lightspeed-agentic-sandbox-main.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift/lightspeed-agentic-sandbox/openshift-lightspeed-agentic-sandbox-main.yaml

Walkthrough

This PR removes nested-podman-based infrastructure from the Lightspeed Agentic Sandbox CI configuration. The change eliminates the nested-podman base image definition, the derived e2e-podman image, and three dependent e2e test jobs for Claude, Gemini, and OpenAI integrations.

Changes

Nested-podman CI configuration cleanup

Layer / File(s) Summary
Remove nested-podman base image and dependent configuration
ci-operator/config/openshift/lightspeed-agentic-sandbox/openshift-lightspeed-agentic-sandbox-main.yaml
Removes the base_images.nested-podman definition, the images block that constructed the e2e-podman image from that base, and the three e2e test jobs (e2e-claude, e2e-gemini, e2e-openai) that used nested-podman capabilities for container-based test execution.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Test Structure And Quality ❓ Inconclusive PR modifies CI/Prow config (YAML), not Ginkgo test code. Custom check requires reviewing test code structure; this is not applicable here. Check not applicable: PR removes e2e test CI configuration, not actual test code. No Ginkgo files are modified.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing e2e integration tests from the agentic OLS configuration. It is specific, concise, and directly reflects the primary objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR removes e2e job definitions from CI YAML config files, not Ginkgo test code. No test names (It(), Describe(), Context()) are modified in the changes.
Microshift Test Compatibility ✅ Passed PR removes e2e test jobs and adds no new Ginkgo e2e tests. Only lint and unit-test jobs remain; check is inapplicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR removes integration tests, not adds new ones. SNO compatibility check only applies to newly added Ginkgo e2e tests, making it not applicable here.
Topology-Aware Scheduling Compatibility ✅ Passed Check does not apply: PR modifies only CI configuration (test job definitions), not deployment manifests, operator code, or controllers. No scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed This PR only modifies YAML CI configuration files (removing e2e test jobs). The OTE Binary Stdout Contract check applies to executable code, not CI configuration.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR removes e2e tests rather than adding new ones. Custom check applies only to "new Ginkgo e2e tests are added" and is not applicable to test removal changes.
No-Weak-Crypto ✅ Passed File is YAML CI configuration with no weak crypto (MD5/SHA1/DES/RC4/3DES/Blowfish/ECB), custom crypto implementations, or non-constant-time secret comparisons.
Container-Privileges ✅ Passed PR removes e2e tests using nested_podman and nested-podman capabilities. Current file has no privileged settings: no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The PR removes e2e tests that logged sensitive data including API keys, Kubernetes tokens, and project IDs. The updated file contains only lint and unit tests with no sensitive credential exposure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@JoaoFula: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-lightspeed-agentic-sandbox-main-images openshift/lightspeed-agentic-sandbox presubmit Ci-operator config changed
pull-ci-openshift-lightspeed-agentic-sandbox-main-lint openshift/lightspeed-agentic-sandbox presubmit Ci-operator config changed
pull-ci-openshift-lightspeed-agentic-sandbox-main-unit-test openshift/lightspeed-agentic-sandbox presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

@JoaoFula: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant