CNTRLPLANE-3561: Migrate OCP-42866 AWS infrastructure creation test#80161
CNTRLPLANE-3561: Migrate OCP-42866 AWS infrastructure creation test#80161mehabhalodiya wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mehabhalodiya: This pull request references OCPSTRAT-2317 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (23)
✅ Files skipped from review due to trivial changes (7)
🚧 Files skipped from review as they are similar to previous changes (12)
WalkthroughAdds CI step-registry entries, scripts, workflow, metadata, and config to provision AWS infra and IAM separately, create a HostedCluster from those artifacts (BYOI), run HyperShift AWS e2e, and tear down infra in a separate cleanup chain. ChangesHyperShift AWS e2e with separate infrastructure provisioning
Estimated code review effort:
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mehabhalodiya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-infra-separate |
|
@mehabhalodiya: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
mehabhalodiya
changed the title
|
@mehabhalodiya: This pull request references CNTRLPLANE-3561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
mehabhalodiya
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
ci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-commands.sh (1)
3-3: ⚡ Quick winDisable default
-xin this step script.Line 3 uses
set -exuo pipefail; for step-registry scripts in this repo, default tracing should be off.Suggested patch
-set -exuo pipefail +set -euo pipefailAs per coding guidelines:
Step-registry scripts should default to set -euo pipefail without -x (tracing) unless actively debugging; enable -x only when necessary and disable it around sensitive operations.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-commands.sh` at line 3, The script currently enables shell tracing via the "set -exuo pipefail" line; update this to remove the -x flag so the step defaults to "set -euo pipefail" (disable tracing by default) and, if tracing is ever needed, enable -x only temporarily around debugging blocks. Locate the "set -exuo pipefail" invocation in the hypershift-aws-create-iam-commands.sh script and change it to omit -x, keeping -euo pipefail intact to preserve strict error handling.ci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-commands.sh (1)
3-3: ⚡ Quick winRemove default xtrace in step-registry scripts.
Line 3 enables
-xby default; this repo’s step-registry guidance expectsset -euo pipefailunless actively debugging.Suggested patch
-set -exuo pipefail +set -euo pipefailAs per coding guidelines:
Step-registry scripts should default to set -euo pipefail without -x (tracing) unless actively debugging; enable -x only when necessary and disable it around sensitive operations.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-commands.sh` at line 3, The top-level shell options invocation currently enables xtrace; remove the xtrace flag so the script defaults to error/undefined-variable/pipefail behavior only. Locate the set invocation at the top of hypershift-aws-create-infra-commands.sh that includes the -x flag and change it to use only the e, u and pipefail options; if you need tracing for debugging, enable xtrace temporarily during the debug session or around non-sensitive blocks and disable it before handling secrets.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-commands.sh`:
- Around line 13-26: The script reads INFRA_ID and extracts PUBLIC_ZONE_ID,
PRIVATE_ZONE_ID and LOCAL_ZONE_ID without validating inputs which can produce
"null" or empty values and cause destructive IAM calls; update the logic to
first verify the infra-id file exists before assigning INFRA_ID, then validate
that PUBLIC_ZONE_ID and PRIVATE_ZONE_ID are non-empty and not "null" (and
optionally that LOCAL_ZONE_ID is either non-empty or set to an empty string) and
if any required value is missing print an explicit error and exit 1 before
proceeding to IAM creation; reference the variables INFRA_ID, INFRA_JSON,
PUBLIC_ZONE_ID, PRIVATE_ZONE_ID and LOCAL_ZONE_ID when adding the checks so the
failure occurs early and prevents building the IAM command with invalid inputs.
---
Nitpick comments:
In
`@ci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-commands.sh`:
- Line 3: The script currently enables shell tracing via the "set -exuo
pipefail" line; update this to remove the -x flag so the step defaults to "set
-euo pipefail" (disable tracing by default) and, if tracing is ever needed,
enable -x only temporarily around debugging blocks. Locate the "set -exuo
pipefail" invocation in the hypershift-aws-create-iam-commands.sh script and
change it to omit -x, keeping -euo pipefail intact to preserve strict error
handling.
In
`@ci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-commands.sh`:
- Line 3: The top-level shell options invocation currently enables xtrace;
remove the xtrace flag so the script defaults to
error/undefined-variable/pipefail behavior only. Locate the set invocation at
the top of hypershift-aws-create-infra-commands.sh that includes the -x flag and
change it to use only the e, u and pipefail options; if you need tracing for
debugging, enable xtrace temporarily during the debug session or around
non-sensitive blocks and disable it before handling secrets.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d2d7163f-3ac7-4863-a0e7-db8ad8896af4
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (11)
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yamlci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-commands.shci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-ref.yamlci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-commands.shci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-ref.yamlci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-commands.shci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-ref.yamlci-operator/step-registry/hypershift/aws/destroy-infra-separate/hypershift-aws-destroy-infra-separate-chain.yamlci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-commands.shci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-ref.yamlci-operator/step-registry/hypershift/aws/e2e-infra-separate/hypershift-aws-e2e-infra-separate-workflow.yaml
mehabhalodiya
force-pushed
the
migrate_OCP42866
branch
from
da10b0c to
708b776
Compare
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-infra-separate |
|
@mehabhalodiya: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Actionable comments posted: 8
🧹 Nitpick comments (1)
ci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-commands.sh (1)
75-75: 💤 Low valueCheck exit code directly instead of using
$?.Consider checking the timeout command's exit code directly for better readability.
♻️ Suggested refactor
-if [[ $? -ne 0 ]]; then +if ! timeout 25m bash -c ' + until [[ "$(oc get -n clusters hostedcluster/${CLUSTER_NAME} -o jsonpath='"'"'{.status.version.history[?(@.state!="")].state}'"'"')" = "Completed" ]]; do + sleep 15 + done +'; then cat << EOF > ${ARTIFACT_DIR}/junit_hosted_cluster.xmlNote: This would require restructuring to move the timeout check inline with the if statement.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-commands.sh` at line 75, The current conditional uses the shell special variable `$?` after running `timeout`, which reduces clarity; instead, restructure the logic to test `timeout`'s exit status directly by running `timeout` in the `if`/`if !` statement (e.g., `if ! timeout ...; then` or `if timeout ...; then`) so you don't rely on `$?` afterward—locate the `timeout` invocation and the surrounding `if [[ $? -ne 0 ]]; then` check and replace them with a direct `if` test against the `timeout` command's result to handle the timeout/failure branch immediately.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-commands.sh`:
- Line 17: CLUSTER_NAME assignment uses unquoted ${SHARED_DIR} in command
substitution which can cause word splitting; update the CLUSTER_NAME assignment
(the line that sets CLUSTER_NAME) to quote the variable expansion inside the
command substitution so the cat command receives a single path (i.e., use "$(cat
"${SHARED_DIR}/cluster-name")"), ensuring any spaces or special chars in
SHARED_DIR are handled safely.
- Line 92: The redirection target uses an unquoted variable (${ARTIFACT_DIR})
which can cause word-splitting if ARTIFACT_DIR contains spaces; update the
here-doc redirection in the script (the cat << EOF line that creates
junit_hosted_cluster.xml) to quote the expansion, e.g. redirect to
"${ARTIFACT_DIR}/junit_hosted_cluster.xml" so the filename is treated as a
single token.
- Around line 61-64: The shell commands use unquoted variable expansions which
can cause word-splitting; update the oc wait invocation and the hypershift
kubeconfig command to quote expansions for CLUSTER_NAME and the output path
(e.g., use "--name=\"${CLUSTER_NAME}\"" and redirect to
"\"${SHARED_DIR}/nested_kubeconfig\"" or quote the whole argument) so oc wait
--for=condition=Available --namespace=clusters hostedcluster/${CLUSTER_NAME} and
bin/hypershift create kubeconfig --namespace=clusters --name=${CLUSTER_NAME}
>${SHARED_DIR}/nested_kubeconfig become variants that quote ${CLUSTER_NAME} and
${SHARED_DIR}/nested_kubeconfig to prevent word splitting and globbing.
- Around line 76-84: The JUnit file generation uses unquoted variable expansions
which can cause word-splitting; update the redirection and the OC command
expansions to be quoted: change the redirect target to use
"${ARTIFACT_DIR}/junit_hosted_cluster.xml" and quote the cluster name in the
embedded OC calls (hostedcluster/"${CLUSTER_NAME}" or otherwise wrap
${CLUSTER_NAME} in quotes) in the here-doc that writes junit_hosted_cluster.xml
so the ARTIFACT_DIR and CLUSTER_NAME expansions are protected from splitting;
ensure you update both occurrences of the oc get -n clusters
hostedcluster/${CLUSTER_NAME} lines.
In
`@ci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-commands.sh`:
- Line 16: The CLUSTER_NAME assignment uses an unquoted expansion of PROW_JOB_ID
which can cause word splitting/globbing; update the assignment that builds
CLUSTER_NAME (the line using PROW_JOB_ID | sha256sum | cut -c-20) to quote the
variable expansion (i.e., use "$PROW_JOB_ID") so the pipeline (sha256sum and
cut) always receives the intended single argument.
- Line 8: The assignment to HC_REGION uses an unquoted fallback expansion which
can cause word splitting/globbing; update the assignment to quote the expansion
so either HC_REGION="${HYPERSHIFT_AWS_REGION:-$LEASED_RESOURCE}" or
HC_REGION=${HYPERSHIFT_AWS_REGION:-"$LEASED_RESOURCE"} (ensure the final value
is quoted) to prevent splitting, referencing the HC_REGION variable and the
HYPERSHIFT_AWS_REGION/LEASED_RESOURCE expansions.
In
`@ci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-commands.sh`:
- Around line 20-21: The shell snippet reading INFRA_ID and CLUSTER_NAME uses
unquoted ${SHARED_DIR} expansions which can cause word-splitting; update the
command substitutions in the INFRA_ID and CLUSTER_NAME assignments (the lines
referencing INFRA_ID and CLUSTER_NAME) to quote the directory variable (e.g.,
use "$(cat "${SHARED_DIR}/infra-id")" and "$(cat "${SHARED_DIR}/cluster-name"
2>/dev/null || echo '')") so the path is treated as a single token and preserves
whitespace or glob characters.
- Line 7: The HC_REGION assignment uses an unquoted fallback $LEASED_RESOURCE
which can cause word splitting or globbing; update the assignment for variable
HC_REGION to quote the expansions (reference HC_REGION, HYPERSHIFT_AWS_REGION,
and LEASED_RESOURCE) so the fallback value is used as a single string and is
safe from splitting/globbing.
---
Nitpick comments:
In
`@ci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-commands.sh`:
- Line 75: The current conditional uses the shell special variable `$?` after
running `timeout`, which reduces clarity; instead, restructure the logic to test
`timeout`'s exit status directly by running `timeout` in the `if`/`if !`
statement (e.g., `if ! timeout ...; then` or `if timeout ...; then`) so you
don't rely on `$?` afterward—locate the `timeout` invocation and the surrounding
`if [[ $? -ne 0 ]]; then` check and replace them with a direct `if` test against
the `timeout` command's result to handle the timeout/failure branch immediately.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 618449be-7e7e-4a77-b0dd-d3bbb4e9187e
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (23)
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yamlci-operator/step-registry/hypershift/aws/create-cluster-byoi/OWNERSci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-commands.shci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-ref.metadata.jsonci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-ref.yamlci-operator/step-registry/hypershift/aws/create-iam/OWNERSci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-commands.shci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-ref.metadata.jsonci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-ref.yamlci-operator/step-registry/hypershift/aws/create-infra/OWNERSci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-commands.shci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-ref.metadata.jsonci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-ref.yamlci-operator/step-registry/hypershift/aws/destroy-infra-separate/OWNERSci-operator/step-registry/hypershift/aws/destroy-infra-separate/hypershift-aws-destroy-infra-separate-chain.metadata.jsonci-operator/step-registry/hypershift/aws/destroy-infra-separate/hypershift-aws-destroy-infra-separate-chain.yamlci-operator/step-registry/hypershift/aws/destroy-infra/OWNERSci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-commands.shci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-ref.metadata.jsonci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-ref.yamlci-operator/step-registry/hypershift/aws/e2e-infra-separate/OWNERSci-operator/step-registry/hypershift/aws/e2e-infra-separate/hypershift-aws-e2e-infra-separate-workflow.metadata.jsonci-operator/step-registry/hypershift/aws/e2e-infra-separate/hypershift-aws-e2e-infra-separate-workflow.yaml
✅ Files skipped from review due to trivial changes (9)
- ci-operator/step-registry/hypershift/aws/create-iam/OWNERS
- ci-operator/step-registry/hypershift/aws/create-infra/OWNERS
- ci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-ref.metadata.json
- ci-operator/step-registry/hypershift/aws/create-cluster-byoi/OWNERS
- ci-operator/step-registry/hypershift/aws/destroy-infra-separate/OWNERS
- ci-operator/step-registry/hypershift/aws/destroy-infra/OWNERS
- ci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-ref.metadata.json
- ci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-ref.metadata.json
- ci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-ref.metadata.json
🚧 Files skipped from review as they are similar to previous changes (7)
- ci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-ref.yaml
- ci-operator/step-registry/hypershift/aws/e2e-infra-separate/hypershift-aws-e2e-infra-separate-workflow.yaml
- ci-operator/step-registry/hypershift/aws/destroy-infra-separate/hypershift-aws-destroy-infra-separate-chain.yaml
- ci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-ref.yaml
- ci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-ref.yaml
- ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
- ci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-commands.sh
mehabhalodiya
force-pushed
the
migrate_OCP42866
branch
2 times, most recently
from
8db8524 to
de7bc7f
Compare
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-infra-separate |
|
@mehabhalodiya: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-infra-separate |
|
@mehabhalodiya: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-commands.sh`:
- Line 3: The script enables tracing with "set -exuo pipefail" but must
temporarily disable tracing around sensitive operations: wrap the kubeconfig
creation block (the command(s) that write or export kubeconfig) with "set +x"
before and "set -x" after, and do the same around the cluster condition
fetch/print commands (the commands that query cluster conditions/URLs and print
them); ensure you only disable tracing for the minimal command sequences and
restore "set -x" immediately afterward so tracing remains enabled elsewhere.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: ee5e52be-fda2-4c19-9a02-aebb5ba083cf
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (23)
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yamlci-operator/step-registry/hypershift/aws/create-cluster-byoi/OWNERSci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-commands.shci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-ref.metadata.jsonci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-ref.yamlci-operator/step-registry/hypershift/aws/create-iam/OWNERSci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-commands.shci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-ref.metadata.jsonci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-ref.yamlci-operator/step-registry/hypershift/aws/create-infra/OWNERSci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-commands.shci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-ref.metadata.jsonci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-ref.yamlci-operator/step-registry/hypershift/aws/destroy-infra-separate/OWNERSci-operator/step-registry/hypershift/aws/destroy-infra-separate/hypershift-aws-destroy-infra-separate-chain.metadata.jsonci-operator/step-registry/hypershift/aws/destroy-infra-separate/hypershift-aws-destroy-infra-separate-chain.yamlci-operator/step-registry/hypershift/aws/destroy-infra/OWNERSci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-commands.shci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-ref.metadata.jsonci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-ref.yamlci-operator/step-registry/hypershift/aws/e2e-infra-separate/OWNERSci-operator/step-registry/hypershift/aws/e2e-infra-separate/hypershift-aws-e2e-infra-separate-workflow.metadata.jsonci-operator/step-registry/hypershift/aws/e2e-infra-separate/hypershift-aws-e2e-infra-separate-workflow.yaml
✅ Files skipped from review due to trivial changes (10)
- ci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-ref.metadata.json
- ci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-ref.metadata.json
- ci-operator/step-registry/hypershift/aws/create-infra/OWNERS
- ci-operator/step-registry/hypershift/aws/create-iam/OWNERS
- ci-operator/step-registry/hypershift/aws/destroy-infra/OWNERS
- ci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-ref.metadata.json
- ci-operator/step-registry/hypershift/aws/create-cluster-byoi/OWNERS
- ci-operator/step-registry/hypershift/aws/e2e-infra-separate/hypershift-aws-e2e-infra-separate-workflow.metadata.json
- ci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-ref.metadata.json
- ci-operator/step-registry/hypershift/aws/destroy-infra-separate/hypershift-aws-destroy-infra-separate-chain.metadata.json
🚧 Files skipped from review as they are similar to previous changes (11)
- ci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-ref.yaml
- ci-operator/step-registry/hypershift/aws/destroy-infra-separate/OWNERS
- ci-operator/step-registry/hypershift/aws/e2e-infra-separate/hypershift-aws-e2e-infra-separate-workflow.yaml
- ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
- ci-operator/step-registry/hypershift/aws/create-cluster-byoi/hypershift-aws-create-cluster-byoi-ref.yaml
- ci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-ref.yaml
- ci-operator/step-registry/hypershift/aws/create-infra/hypershift-aws-create-infra-commands.sh
- ci-operator/step-registry/hypershift/aws/destroy-infra-separate/hypershift-aws-destroy-infra-separate-chain.yaml
- ci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-commands.sh
- ci-operator/step-registry/hypershift/aws/destroy-infra/hypershift-aws-destroy-infra-ref.yaml
- ci-operator/step-registry/hypershift/aws/create-iam/hypershift-aws-create-iam-commands.sh
mehabhalodiya
force-pushed
the
migrate_OCP42866
branch
from
de7bc7f to
71b7e25
Compare
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-infra-separate |
|
@mehabhalodiya: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Add step-registry components and CI job to test AWS infrastructure creation as a separate step, supporting migration of test OCP-42866 from openshift-tests-private to openshift/hypershift. Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
mehabhalodiya
force-pushed
the
migrate_OCP42866
branch
from
71b7e25 to
06c8a5a
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-infra-separate |
|
@mehabhalodiya: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mehabhalodiya: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
OCPSTRAT-2317: Migrate OCP-42866 AWS infrastructure creation test
Add step-registry components and CI job to test AWS infrastructure
creation as a separate step, supporting migration of test OCP-42866
from openshift-tests-private to openshift/hypershift.
This change creates a new e2e-aws-infra-separate workflow that:
This workflow leverages native hypershift CLI commands:
New step-registry components:
New CI job:
This pattern enables validation of infrastructure provisioning independently from cluster creation, addressing the test coverage gap identified in OCPSTRAT-2317 Phase 2.
Summary by CodeRabbit
This PR updates OpenShift CI configuration (openshift/release) to add a dedicated HyperShift workflow and step-registry components that validate AWS infrastructure provisioning separately from HostedCluster creation. It enables running the OCP-42866 infra creation test as a standalone CI flow (BYOI pattern) so infrastructure can be provisioned, validated, and torn down independently of cluster creation.
What changed (practical impact)
Why this matters