OCPBUGS-86961: CI job kubevirt-metal-ovn-multinet fails to install MetalLB operator

[amogh-redhat]

What this PR does / why we need it :

The following jobs fails to install MetalLB operator:

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet/2060843873688621056

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet-default-net/2060934532646834176

The configurations for the jobs are stored in “ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml” .

METALLB_OPERATOR_SUB_SOURCE variable is missing for the below tests:

e2e-kubevirt-metal-ovn-multinet
e2e-kubevirt-metal-ovn-multinet-default-net

This is the reason why the job looks for METALLB_OPERATOR_SUB_SOURCE value in the workflow yaml - “ci-operator/step-registry/hypershift/mce/kubevirt/baremetalds/conformance/hypershift-mce-kubevirt-baremetalds-conformance-workflow.yaml”.
The METALLB_OPERATOR_SUB_SOURCE value is defined as “qe-app-registry” in the workflow yaml.
This is causing the error, as the OLM operator couldn’t find “metallb-operator” in “qe-app-registry”.
To fix this, i have adds the “METALLB_OPERATOR_SUB_SOURCE: metallb-konflux” for both the tests mentioned above under the “env:”.

Other tests that are running for the same version already have this variable under "env".
example - e2e-kubevirt-metal-ovn, e-agent-connected-ovn-ipv4-metal-conformance.

Which issue(s) this PR fixes: Fixes - https://redhat.atlassian.net/browse/OCPBUGS-86961

Special notes for your reviewer:

Checklist:
Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

Summary by CodeRabbit

This PR updates OpenShift CI configuration for HyperShift MCE periodic jobs (ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml) to fix MetalLB operator installation failures in the KubeVirt baremetal multinetwork conformance jobs (e2e-kubevirt-metal-ovn-multinet and e2e-kubevirt-metal-ovn-multinet-default-net).

What changed (practical impact):

• The two failing jobs' env blocks now enable Konflux catalog/operator deployment and set the correct MetalLB catalog source:
  • KONFLUX_DEPLOY_CATALOG_SOURCE: "true"
  • KONFLUX_DEPLOY_OPERATORS: "true"
  • KONFLUX_DEPLOY_SUBSCRIPTION: "false"
  • METALLB_OPERATOR_SUB_SOURCE: metallb-konflux
• These settings ensure the test workflow fetches metallb-operator from the metallb-konflux catalog (instead of falling back to qe-app-registry where metallb-operator is absent), allowing OLM subscription/installation to succeed.

Scope/impact:

• Affects periodic CI jobs for HyperShift MCE KubeVirt multinetwork conformance on the 4.22 manifest—enables the MetalLB operator to be deployed from the intended catalog and prevents OLM install failures that previously broke these tests.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@amogh-redhat: This pull request references Jira Issue OCPBUGS-86961, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it :

The following jobs fails to install MetalLB operator:

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet/2060843873688621056

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet-default-net/2060934532646834176

The configurations for the jobs are stored in “ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml” .

METALLB_OPERATOR_SUB_SOURCE variable is missing for the below tests:

e2e-kubevirt-metal-ovn-multinet
e2e-kubevirt-metal-ovn-multinet-default-net

This is the reason why the job looks for METALLB_OPERATOR_SUB_SOURCE value in the workflow yaml - “ci-operator/step-registry/hypershift/mce/kubevirt/baremetalds/conformance/hypershift-mce-kubevirt-baremetalds-conformance-workflow.yaml”.
The METALLB_OPERATOR_SUB_SOURCE value is defined as “qe-app-registry” in the workflow yaml.
This is causing the error, as the OLM operator couldn’t find “metallb-operator” in “qe-app-registry”.
To fix this, i have adds the “METALLB_OPERATOR_SUB_SOURCE: metallb-konflux” for both the tests mentioned above under the “env:”.

Other tests that are running for the same version already have this variable under "env".
example - e2e-kubevirt-metal-ovn, e-agent-connected-ovn-ipv4-metal-conformance.

Which issue(s) this PR fixes: Fixes - https://redhat.atlassian.net/browse/OCPBUGS-86961

Special notes for your reviewer:
Checklist:
Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 39498730-2c4c-4441-87cb-2aacbe4985e9

📥 Commits

Reviewing files that changed from the base of the PR and between ca01e6f and a0462ac.

📒 Files selected for processing (1)

• ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml

---

Walkthrough

This PR updates two hypershift MCE periodic Prow job env blocks to add Konflux deployment flags (KONFLUX_DEPLOY_CATALOG_SOURCE, KONFLUX_DEPLOY_OPERATORS, KONFLUX_DEPLOY_SUBSCRIPTION) and METALLB_OPERATOR_SUB_SOURCE: metallb-konflux.

Changes

MCE MetalLB Operator Environment Configuration

Layer / File(s)	Summary
Konflux and MetalLB env additions ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml	Adds KONFLUX_DEPLOY_CATALOG_SOURCE: "true", KONFLUX_DEPLOY_OPERATORS: "true", KONFLUX_DEPLOY_SUBSCRIPTION: "false", and METALLB_OPERATOR_SUB_SOURCE: metallb-konflux to the env blocks for e2e-kubevirt-metal-ovn-multinet and e2e-kubevirt-metal-ovn-multinet-default-net periodic jobs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• openshift/release#78382: Updates the same hypershift MCE Konflux operator environment configuration and sets METALLB_OPERATOR_SUB_SOURCE in related Prow job configs.

Suggested labels

rehearsals-ack

Suggested reviewers

• csrwng

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing CI job failures for MetalLB operator installation by adding required environment variables to the job configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only YAML CI job configuration, not Ginkgo test code. Check for Ginkgo test names is not applicable to non-test code changes.
Test Structure And Quality	✅ Passed	PR modifies only YAML CI operator configuration files, not Ginkgo test code; custom check for test code quality is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added. This PR only modifies YAML CI configuration to add environment variables to existing test jobs. The check for MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies only YAML CI job configuration, not adding new Ginkgo e2e tests. SNO compatibility check only applies when new test code (It/Describe/etc.) is added.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only CI configuration (environment variables for test jobs), not deployment manifests or operator code. No scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	PR only modifies YAML configuration files to fix MetalLB operator installation issues; no executable code changes affect OTE binary stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies only CI configuration YAML (environment variables in test job definitions), not Ginkgo test code. No new It(), Describe(), Context(), When(), or similar test constructs are added.
No-Weak-Crypto	✅ Passed	PR contains only YAML CI/CD configuration changes with no cryptographic code, making the weak-crypto check not applicable.
Container-Privileges	✅ Passed	The PR modifies a CI config file adding environment variables only. No container security manifests with privilege escalation settings exist in this change.
No-Sensitive-Data-In-Logs	✅ Passed	Environment variables added are non-sensitive configuration flags and catalog source names; no passwords, tokens, API keys, PII, or credentials exposed in logs.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[amogh-redhat]

/hold

[amogh-redhat]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet

[openshift-merge-bot]

@amogh-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mgencur]

/lgtm

The workflow already has the required:

KONFLUX_DEPLOY_OPERATORS: "false"
KONFLUX_TARGET_OPERATORS: metallb,local-storage

So, adding this variable should suffice.

[mgencur]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet

[openshift-merge-bot]

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amogh-redhat, mgencur
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mgencur]

Actually, the tests require all of these:

KONFLUX_DEPLOY_CATALOG_SOURCE: "true"
KONFLUX_DEPLOY_OPERATORS: "true"
KONFLUX_DEPLOY_SUBSCRIPTION: "false"

In the latest run, the CatalogSource was not deployed

[openshift-ci]

New changes are detected. LGTM label has been removed.

[amogh-redhat]

Thank you @mgencur . I have added the variables.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@amogh-redhat: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet-default-net	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[amogh-redhat]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet

[openshift-merge-bot]

@amogh-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[amogh-redhat]

The error - "Nested cluster's node count is not equal to the desired replicas in the NodePool. Retrying in 30 seconds." doesn't look to be an issue with the changes I made. It looks more of an issue with an infrastructure/resource issue. I will initiate the test again.

[amogh-redhat]

/retest

[amogh-redhat]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet

[openshift-merge-bot]

@amogh-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mgencur]

You're on a good way. The metallb install step already passed in the latest run.

[amogh-redhat]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet

[openshift-merge-bot]

@amogh-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@amogh-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet	a0462ac	link	unknown	/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.