Skip to content

no-jira: aws: skip IPv6DualStack hostNetwork test in AWS dualstack techpreview presubmits#80172

Open
tthvo wants to merge 1 commit into
openshift:mainfrom
tthvo:dualstack-presubmit
Open

no-jira: aws: skip IPv6DualStack hostNetwork test in AWS dualstack techpreview presubmits#80172
tthvo wants to merge 1 commit into
openshift:mainfrom
tthvo:dualstack-presubmit

Conversation

@tthvo
Copy link
Copy Markdown
Member

@tthvo tthvo commented Jun 5, 2026

The periodic jobs (e2e-aws-ovn-installer-dualstack-{ipv4,ipv6}-primary-techpreview) already skip this test. Apply the same TEST_SKIPS to the installer presubmit dualstack techpreview jobs for consistency.

We should remove TEST_SKIPS once the upstream test is fixed and re-enable running these tests.

See kubernetes/kubernetes#121018

Summary by CodeRabbit

This PR adds test skip configurations to the OpenShift installer's AWS OVN dual-stack techpreview presubmit jobs across multiple release branches (main, 4.22, 4.23, 5.0, and 5.1).

What's changing:

The PR adds a TEST_SKIPS environment variable to both the IPv4-primary and IPv6-primary variants of the e2e-aws-ovn-dualstack-techpreview jobs in each release branch. The skip targets this specific test case:

[sig-network] [Feature:IPv6DualStack] Granular Checks: Services Secondary IP Family [LinuxOnly] should function for service endpoints using hostNetwork

Why:

This change aligns the presubmit job behavior with existing periodic jobs. The IPv6DualStack hostNetwork test is being skipped due to an upstream Kubernetes issue (kubernetes#121018). The TEST_SKIPS are temporary and should be removed once the upstream issue is resolved.

Impact:

  • 5 CI configuration files modified (+6 lines each = +30 total)
  • Affects AWS dual-stack validation pipelines for OpenShift versions main, 4.22, 4.23, 5.0, and 5.1
  • No changes to actual test code or production components—this is purely CI infrastructure configuration
  • Prevents known failures from blocking dual-stack presubmit checks while the upstream Kubernetes bug is being fixed

…review presubmits

The periodic jobs (e2e-aws-ovn-installer-dualstack-{ipv4,ipv6}-primary-techpreview)
already skip this test. Apply the same TEST_SKIPS to the installer presubmit
dualstack techpreview jobs for consistency.

TODO: Remove TEST_SKIPS once the upstream test is fixed and re-enable
running these tests. See kubernetes/kubernetes#121018

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@tthvo: This pull request explicitly references no jira issue.

Details

In response to this:

The periodic jobs (e2e-aws-ovn-installer-dualstack-{ipv4,ipv6}-primary-techpreview) already skip this test. Apply the same TEST_SKIPS to the installer presubmit dualstack techpreview jobs for consistency.

We should remove TEST_SKIPS once the upstream test is fixed and re-enable running these tests.

See kubernetes/kubernetes#121018

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3de39c20-6e01-4a4c-8791-ea5d4320f579

📥 Commits

Reviewing files that changed from the base of the PR and between b7407a3 and 42db75c.

📒 Files selected for processing (5)
  • ci-operator/config/openshift/installer/openshift-installer-main.yaml
  • ci-operator/config/openshift/installer/openshift-installer-release-4.22.yaml
  • ci-operator/config/openshift/installer/openshift-installer-release-4.23.yaml
  • ci-operator/config/openshift/installer/openshift-installer-release-5.0.yaml
  • ci-operator/config/openshift/installer/openshift-installer-release-5.1.yaml

Walkthrough

Five OpenShift installer CI configuration files are updated to consistently skip a specific sig-network IPv6DualStack test case. The same TEST_SKIPS environment variable is added to both IPv4-primary and IPv6-primary dual-stack tech preview e2e jobs in all release branches, targeting secondary IP family hostNetwork service endpoint checks.

Changes

IPv6 Dual-Stack HostNetwork Test Skip

Layer / File(s) Summary
Test skip configuration across release branches
ci-operator/config/openshift/installer/openshift-installer-main.yaml, ci-operator/config/openshift/installer/openshift-installer-release-4.22.yaml, ci-operator/config/openshift/installer/openshift-installer-release-4.23.yaml, ci-operator/config/openshift/installer/openshift-installer-release-5.0.yaml, ci-operator/config/openshift/installer/openshift-installer-release-5.1.yaml
TEST_SKIPS environment variable is added uniformly to both e2e-aws-ovn-dualstack-ipv4-primary-techpreview and e2e-aws-ovn-dualstack-ipv6-primary-techpreview jobs across main and five release branches. All instances skip the same sig-network IPv6DualStack granular check for secondary IP family using hostNetwork.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

ok-to-test, rehearsals-ack

Suggested reviewers

  • tssurya
  • martinkennelly
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding TEST_SKIPS to skip an IPv6DualStack hostNetwork test in AWS dualstack techpreview presubmit jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration YAML files with TEST_SKIPS directives, not Ginkgo test definitions. The check applies to test code, not CI configs.
Test Structure And Quality ✅ Passed PR modifies only YAML CI configuration files, not Ginkgo test code. The custom check is not applicable as it requires review of actual test code files.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added. PR only modifies CI operator YAML configurations to skip existing tests via TEST_SKIPS environment variables.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies YAML CI configuration files, adding TEST_SKIPS environment variables to skip an existing upstream test. No new Ginkgo e2e tests are added, so the check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI test job configurations only, not deployment manifests, operator code, or scheduling constraints. TEST_SKIPS is a test control mechanism, not a topology-dependent scheduling rule.
Ote Binary Stdout Contract ✅ Passed PR modifies only CI configuration YAML files (TEST_SKIPS environment variables); no source code changes. OTE Binary Stdout Contract check applies only to executable code, not configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies CI configuration files to skip an existing test, not adding new Ginkgo e2e tests; custom check applies only to new test additions.
No-Weak-Crypto ✅ Passed This PR modifies only CI/CD YAML configuration files adding TEST_SKIPS environment variables for test jobs. No cryptographic code, weak crypto algorithms, or secret comparisons are present.
Container-Privileges ✅ Passed PR modifies CI job configuration files only, adding TEST_SKIPS environment variables for test pattern matching. No container privilege specifications or security contexts are present.
No-Sensitive-Data-In-Logs ✅ Passed Pull request adds only test case identifiers to TEST_SKIPS environment variables; contains no passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from rwsu and sadasu June 5, 2026 20:51
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@tthvo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-release-4.22-e2e-aws-ovn-dualstack-ipv4-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.22-e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-5.0-e2e-aws-ovn-dualstack-ipv4-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-5.0-e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-dualstack-ipv4-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-5.1-e2e-aws-ovn-dualstack-ipv4-primary-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-5.1-e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/installer presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@tthvo
Copy link
Copy Markdown
Member Author

tthvo commented Jun 5, 2026

/pj-rehearse pull-ci-openshift-installer-release-5.0-e2e-aws-ovn-dualstack-ipv6-primary-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@tthvo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tthvo
Copy link
Copy Markdown
Member Author

tthvo commented Jun 5, 2026

/pj-rehearse pull-ci-openshift-installer-release-5.0-e2e-aws-ovn-dualstack-ipv4-primary-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@tthvo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tthvo
Copy link
Copy Markdown
Member Author

tthvo commented Jun 5, 2026

/cc @patrickdillon

@openshift-ci openshift-ci Bot requested a review from patrickdillon June 5, 2026 21:20
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 6, 2026

@tthvo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants