Skip to content

NO-JIRA: ci(release-4.20): retire TNF tech-preview periodic jobs#80173

Open
jaypoulz wants to merge 1 commit into
openshift:mainfrom
jaypoulz:retire-tnf-4.20
Open

NO-JIRA: ci(release-4.20): retire TNF tech-preview periodic jobs#80173
jaypoulz wants to merge 1 commit into
openshift:mainfrom
jaypoulz:retire-tnf-4.20

Conversation

@jaypoulz
Copy link
Copy Markdown
Contributor

@jaypoulz jaypoulz commented Jun 5, 2026

TNF (two-node-fencing) testing retired for release 4.20 since the installs have a high failure rate that is fixed in 4.21 TP and 4.22+ GA.

The cost to reimplement the fixes in 4.20 is not worth it, so 4.20 will join 4.19 as retired lanes.

Summary by CodeRabbit

This PR retires the two-node-fencing (TNF) tech-preview periodic test jobs from the OpenShift 4.20 release nightly CI pipeline. The jobs being removed are e2e-metal-ovn-two-node-fencing-techpreview and e2e-metal-ovn-two-node-fencing-recovery-techpreview.

Why: The TNF tests have a consistently high failure rate for 4.20 installations. While the underlying issue is fixed in 4.21 TP and 4.22+ GA releases, backporting those fixes to 4.20 is not considered cost-justified. This change brings 4.20 in line with 4.19, which also has TNF testing disabled.

What changed: The change removes these test jobs from the nightly 4.20 Prow job configuration file (ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml), effectively stopping the periodic execution of these tests in the 4.20 CI pipeline.

TNF (two-node-fencing) testing retired for release 4.20 since the installs
have a high failure rate that is fixed in 4.21 TP and 4.22+ GA.

The cost to reimplement the fixes in 4.20 is not worth it, so 4.20 will
join 4.19 as retired lanes.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@jaypoulz: This pull request explicitly references no jira issue.

Details

In response to this:

TNF (two-node-fencing) testing retired for release 4.20 since the installs have a high failure rate that is fixed in 4.21 TP and 4.22+ GA.

The cost to reimplement the fixes in 4.20 is not worth it, so 4.20 will join 4.19 as retired lanes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 620583f6-2fe3-43a5-b083-ea8cf6f153e3

📥 Commits

Reviewing files that changed from the base of the PR and between b7407a3 and f9b8abe.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml

Walkthrough

This pull request updates the nightly 4.20 release CI configuration by removing two deprecated fencing techpreview test jobs and introducing a new workload-partitioning test job for the two-node arbiter platform in the test orchestration list.

Changes

Two-node arbiter test jobs

Layer / File(s) Summary
Two-node arbiter test job replacement
ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml
The e2e-metal-ovn-two-node-fencing-techpreview and e2e-metal-ovn-two-node-fencing-recovery-techpreview test jobs are removed from the test configuration, and the e2e-metal-ovn-two-node-arbiter-workload-partitioning job is added with its scheduling and workflow settings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Suggested labels

lgtm, rehearsals-ack

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: retiring TNF tech-preview periodic jobs from the release-4.20 configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI job configuration (YAML), not Ginkgo test code. Check requires examination of Ginkgo test titles in test code, which this PR does not modify.
Test Structure And Quality ✅ Passed PR modifies only CI configuration YAML file, not Ginkgo test code. Custom check for test structure/quality is not applicable to non-test files.
Microshift Test Compatibility ✅ Passed This PR modifies only CI operator configuration files (YAML), not Ginkgo e2e test code. No new tests are added. The check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are limited to CI job configuration (YAML) and utility/infrastructure files. Check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI/CD configuration file (test job definitions), not deployment manifests, operator code, or controllers. Check explicitly applies only to those types of changes.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI configuration (YAML files and utility scripts) in the openshift/release repository. Does not touch OTE binary code or test code that could violate stdout contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only YAML CI configuration files in openshift/release repo, not Ginkgo test code. Check is inapplicable as it applies only to new test code additions.
No-Weak-Crypto ✅ Passed The PR modifies a YAML CI/CD configuration file with no cryptographic code, no weak crypto algorithms, and no custom crypto implementations. Changes are purely configuration-based job retirement.
Container-Privileges ✅ Passed The file is a CI operator config defining periodic test jobs, not a Kubernetes/container manifest. It contains no container security specs or privilege escalation settings that the check flags.
No-Sensitive-Data-In-Logs ✅ Passed The PR modifies CI job configurations in a YAML file with no new logging statements that expose passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bradmwilliams and neisw June 5, 2026 21:04
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jaypoulz: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 5, 2026
@eggfoobar
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

@jaypoulz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaypoulz
Copy link
Copy Markdown
Contributor Author

jaypoulz commented Jun 5, 2026

/hold for ack from team

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2026
@neisw
Copy link
Copy Markdown
Contributor

neisw commented Jun 5, 2026

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2026
@dhensel-rh
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhensel-rh, eggfoobar, jaypoulz, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants