Skip to content

MPICT: Rename ocp-chaos AWS jobs and drop bare-metal node type#82351

Open
oharan2 wants to merge 2 commits into
openshift:mainfrom
oharan2:chaos
Open

MPICT: Rename ocp-chaos AWS jobs and drop bare-metal node type#82351
oharan2 wants to merge 2 commits into
openshift:mainfrom
oharan2:chaos

Conversation

@oharan2

@oharan2 oharan2 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Changes:

  • Renamed test jobs in redhat-chaos-lp-chaos-main__ocp-4.22-ocp-chaos.yaml to be more descriptive of what each runs:
    • cr--ocp--krkn-hub-tests--awscr--pod-disruption-chaos--aws
    • cr--ocp--krkn-hub-node-tests--awscr--node-outage-chaos--aws
  • Changed COMPUTE_NODE_TYPE from m5.metal to m5.large for both jobs, since these clusters don't deploy any products requiring bare-metal nodes.

Summary by CodeRabbit

  • Renames the AWS MPICT chaos test jobs to clarify their coverage: pod disruption and node outage chaos.
  • Changes the AWS compute node type from m5.metal to m5.large, since these clusters do not require bare-metal nodes.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Two AWS cron-driven chaos test definitions were renamed to identify pod disruption and node outage scenarios, and both now use m5.large compute nodes. Their schedules, cluster profiles, and other listed environment values remain unchanged.

Changes

AWS chaos job configuration

Layer / File(s) Summary
Update AWS chaos cron definitions
ci-operator/config/redhat-chaos/lp-chaos/redhat-chaos-lp-chaos-main__ocp-4.22-ocp-chaos.yaml
The AWS pod disruption and node outage jobs receive new identifiers and change COMPUTE_NODE_TYPE from m5.metal to m5.large; cron schedules and other listed settings are retained.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The renamed test/job titles are static strings; they contain no timestamps, IDs, pods, nodes, namespaces, or other dynamic data.
Test Structure And Quality ✅ Passed Only ci-operator/prow YAML changed; no Ginkgo test code, It blocks, or Eventually calls were modified.
Microshift Test Compatibility ✅ Passed PASS: The PR only edits ci-operator YAML job definitions; it adds no Ginkgo tests or code paths using MicroShift-unsupported APIs/features.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAML/periodic job renames changed; no Go e2e tests or SNO-sensitive test logic were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI job names and test runtime settings changed; no deployment manifests, operators, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed PASS — only ci-operator YAML changed; no Go/test binary source or stdout/logging code was modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI job names/node type changed; no Ginkgo test code or network logic was added or modified.
No-Weak-Crypto ✅ Passed Changed YAML only renames jobs and node type; no weak-crypto keywords, custom crypto, or secret/token comparisons were present.
Container-Privileges ✅ Passed PASS — Diff only renames jobs and changes COMPUTE_NODE_TYPE; no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs ✅ Passed Only job names and node type changed; no new logging, secret values, or PII exposure was introduced.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: renaming the AWS chaos jobs and switching off the bare-metal node type.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@oharan2 oharan2 changed the title MPICT: Rename lp-chaos AWS jobs and drop bare-metal node type MPICT: Rename ocp-chaos AWS jobs and drop bare-metal node type Jul 23, 2026
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oharan2
Once this PR has been reviewed and has the lgtm label, please assign paigerube14 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from chaitanyaenr and etirta July 23, 2026 14:04
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@oharan2: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-redhat-chaos-lp-chaos-main-ocp-4.22-ocp-chaos-cr--pod-disruption-chaos--aws N/A periodic Periodic changed
periodic-ci-redhat-chaos-lp-chaos-main-ocp-4.22-ocp-chaos-cr--node-outage-chaos--aws N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@oharan2: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call everything as outage. The #80752 is preparing for that.

Suggested change
- as: cr--outage-pod--aws

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- as: cr--node-outage-node--aws

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, keep it metal for now, until we got confirmation for Virt. Nodes. And even that, it will be intel 8th (or 7th as per their doc.) generattion.

krisnababu added a commit to krisnababu/release that referenced this pull request Jul 24, 2026
- Rename .tests[].as values to cr--cnv--outage-{pod,node,kubevirt}--aws
  to sync with OCP Chaos naming (PR openshift#82351) and CR onboarding format
- Remove :-unknown default from LPC_LP_CNV__VM__SNAPSHOT__OPERATION
  (CI Operator guarantees env vars are set; default hides misconfiguration)
- Add typeset -i to startTime (SECONDS is an integer)
- Regenerate Prow job configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants