Skip to content

Update Node Version For Prometheus-Alertmanager#82355

Open
GeorgeFrankAeillo wants to merge 1 commit into
openshift:mainfrom
GeorgeFrankAeillo:gaeillo/update-node-version-for-prometheus-alertmanager-build
Open

Update Node Version For Prometheus-Alertmanager#82355
GeorgeFrankAeillo wants to merge 1 commit into
openshift:mainfrom
GeorgeFrankAeillo:gaeillo/update-node-version-for-prometheus-alertmanager-build

Conversation

@GeorgeFrankAeillo

@GeorgeFrankAeillo GeorgeFrankAeillo commented Jul 23, 2026

Copy link
Copy Markdown

In the new prometheus-alertmanager, they change how they build the frontend by using go://embed , so a newer node version is required, since the frontend codes depends on a newer version of vite.

Summary by CodeRabbit

  • Updates the Prometheus Alertmanager release pipeline to use Node.js v24.3.0, enabling the frontend build and testing dependency required by the new process.

…ed for testing

Signed-off-by: George Aeillo <gaeillo@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The release test pipeline’s Node.js version changes from v20.12.2 to v24.3.0.

Changes

Release Pipeline

Layer / File(s) Summary
Node.js version update
ci-operator/config/stolostron/prometheus-alertmanager/stolostron-prometheus-alertmanager-release-5.0.yaml
The test command now downloads and uses Node.js v24.3.0 instead of v20.12.2.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes a ci-operator YAML Node.js version; no Ginkgo test titles or test files were modified.
Test Structure And Quality ✅ Passed Only a CI config YAML changed; no Ginkgo test code or test structure was modified, so the check is not applicable.
Microshift Test Compatibility ✅ Passed Only a ci-operator Node.js version bump changed; no Ginkgo/e2e tests were added or modified, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a CI config Node.js bump changed; no Ginkgo tests or multi-node/SNO-sensitive logic were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only a ci-operator test command changed to use Node.js v24.3.0; no manifests, controllers, affinity, node selectors, or PDBs were modified.
Ote Binary Stdout Contract ✅ Passed PR only bumps Node.js in ci-operator YAML; no process-level binary code or stdout writes changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only bumps Node in a ci-operator YAML; no Ginkgo tests or network/IP assumptions were added.
No-Weak-Crypto ✅ Passed Only change is a Node.js version bump in a CI YAML; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The PR only updates a Node.js version in a ci-operator test command; no privileged, host* or allowPrivilegeEscalation settings are present in the changed file.
No-Sensitive-Data-In-Logs ✅ Passed The only change is a Node.js version bump in CI commands; no logs, secrets, PII, or hostnames are introduced.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: updating the Node.js version for Prometheus Alertmanager.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from gurnben and ngraham20 July 23, 2026 15:16
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GeorgeFrankAeillo
Once this PR has been reviewed and has the lgtm label, please assign marcolan018 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@GeorgeFrankAeillo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-prometheus-alertmanager-release-5.0-test stolostron/prometheus-alertmanager presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@GeorgeFrankAeillo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant