Update Node Version For Prometheus-Alertmanager#82355
Conversation
…ed for testing Signed-off-by: George Aeillo <gaeillo@redhat.com>
WalkthroughThe release test pipeline’s Node.js version changes from ChangesRelease Pipeline
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GeorgeFrankAeillo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@GeorgeFrankAeillo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In the new prometheus-alertmanager, they change how they build the frontend by using go://embed , so a newer node version is required, since the frontend codes depends on a newer version of vite.
Summary by CodeRabbit
v24.3.0, enabling the frontend build and testing dependency required by the new process.