Skip to content

chore: remove temp cluster label#82362

Open
jan-law wants to merge 1 commit into
openshift:mainfrom
jan-law:grc-rm-cluster-label
Open

chore: remove temp cluster label#82362
jan-law wants to merge 1 commit into
openshift:mainfrom
jan-law:grc-rm-cluster-label

Conversation

@jan-law

@jan-law jan-law commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Followup to #82025

Remove cluster label added because #82025 PR CI could not select arm64 clusters before the capability config merged

Summary by CodeRabbit

Removes temporary fixed cluster assignments from governance-policy-framework E2E CI configurations across supported releases. ARM64 tests now rely on capability-based cluster selection, while their existing test steps and publishing workflows remain unchanged.

Remove cluster label added because PR CI could not
select arm64 clusters before the capability config merged

Signed-off-by: Janelle Law <jalaw@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2026
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Governance policy framework CI configurations remove fixed cluster assignments from E2E test definitions. Release configurations retain or add ARM64 capability settings while preserving the existing test steps and workflow configuration.

Changes

Governance policy framework CI configuration

Layer / File(s) Summary
Unpin E2E test clusters and configure ARM64 scheduling
ci-operator/config/stolostron/governance-policy-framework/*.yaml
Main and release E2E test definitions remove hardcoded cluster selections; relevant release configurations retain or add arm64 capabilities and preserve existing steps.
Estimated code review effort: 1 (Trivial) ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only removes CI cluster pins in YAML; no Ginkgo specs or test titles were added or changed.
Test Structure And Quality ✅ Passed PR only removes cluster labels from ci-operator YAML; no Ginkgo/Go test code changed, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PR only removes cluster labels from ci-operator YAML; no Go/Ginkgo test files or new It/Describe/Context blocks were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Not applicable: the PR only edits ci-operator YAML; this repo has no new Ginkgo e2e tests or SNO-sensitive test code to review.
Topology-Aware Scheduling Compatibility ✅ Passed PR only removes ci-operator cluster labels from CI job configs; no deployment manifests, controllers, or scheduling constraints were added or changed.
Ote Binary Stdout Contract ✅ Passed Only ci-operator/job YAML changed; no Go/test suite code or stdout-producing OTE entrypoints were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI config changed: cluster labels were removed from YAML; no new or modified Ginkgo test code or external connectivity assumptions were introduced.
No-Weak-Crypto ✅ Passed Diff only removes ci-operator cluster labels in YAML; no weak-crypto algorithms or custom crypto code were changed.
Container-Privileges ✅ Passed PR only removes cluster labels and adds arm64 capabilities; no privileged, hostPID/hostNetwork, SYS_ADMIN, or allowPrivilegeEscalation fields appear in changed manifests.
No-Sensitive-Data-In-Logs ✅ Passed Touched YAMLs only drop cluster selectors; no logging statements or exposed credentials/tokens were added.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: removing temporary cluster labels from CI test configurations.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jan-law

jan-law commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan-law

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jan-law: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-governance-policy-framework-release-2.12-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-5.0-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.17-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.11-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.16-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.15-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.14-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.13-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-main-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jan-law

jan-law commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jan-law

jan-law commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse-skip

The unrelated failures are the same as in #82025 (comment)

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: job(s): /pj-rehearse-skip either don't exist or were not found to be affected, and cannot be rehearsed

@jan-law
jan-law marked this pull request as ready for review July 23, 2026 20:20
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2026
@jan-law

jan-law commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse-skip

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: job(s): /pj-rehearse-skip either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@jan-law: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/governance-policy-framework/release-2.15/test-e2e-grc-framework f3b5380 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.15-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-2.12/test-e2e-grc-framework f3b5380 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.12-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-2.13/test-e2e-grc-framework f3b5380 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.13-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-2.17/test-e2e-grc-framework f3b5380 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.17-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-2.14/test-e2e-grc-framework f3b5380 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.14-test-e2e-grc-framework

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant