Fix InPlacePodVerticalScaling conformance skip regex by dustman9000 · Pull Request #82369 · openshift/release

dustman9000 · 2026-07-23T17:40:48Z

Summary

Fix the TEST_SKIPS pattern for InPlacePodVerticalScaling that never matched, causing the HCP Conformance 5.0 job to persistently fail.

Problem

The skip pattern InPlacePodVerticalScaling.*decrease memory limit below usage expects InPlacePodVerticalScaling to appear before decrease memory limit below usage in the test name. But the actual test name is:

[sig-node] Pod InPlace Resize Container decrease memory limit below usage [Feature:InPlacePodVerticalScaling]

The [Feature:InPlacePodVerticalScaling] tag comes AFTER decrease memory limit below usage, so the .* regex never matches. Additionally, the broader skip uses [FeatureGate:InPlacePodVerticalScaling] but the test uses [Feature:InPlacePodVerticalScaling] (no "Gate").

Fix

Simplify the skip to just decrease memory limit below usage which matches the test name unambiguously.

Affected files

ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml

Test plan

HCP Conformance 5.0 job stops failing on this test
HCP Conformance 4.22 job not affected negatively

Summary by CodeRabbit

Updates the ROSA AWS HCP conformance workflow and nightly 4.22/5.0 release configurations to fix the TEST_SKIPS regex for the InPlacePodVerticalScaling “decrease memory limit below usage” scenario.
Removes the InPlacePodVerticalScaling.* prefix from the skip entry so the pattern matches the actual conformance test name, ensuring the intended test is skipped.

coderabbitai · 2026-07-23T17:43:00Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3e15185c-95b0-4ffe-bb97-f8385cf5d495

📥 Commits

Reviewing files that changed from the base of the PR and between 473fd3b and 2030ab2.

📒 Files selected for processing (3)

ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml

🚧 Files skipped from review as they are similar to previous changes (3)

ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml

Walkthrough

The ROSA HCP conformance TEST_SKIPS pattern was updated in the shared workflow and nightly 4.22 and 5.0 release configurations by removing the InPlacePodVerticalScaling.* prefix.

Changes

ROSA HCP conformance skip pattern

Layer / File(s)	Summary
Update conformance test filtering `ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml`, `ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml`, `ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`	The affected `TEST_SKIPS` entries now match `decrease memory limit below usage\| CSI Mock volume` without the `InPlacePodVerticalScaling.*` prefix.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

openshift/release#82321: Updates related ROSA AWS HCP conformance TEST_SKIPS patterns.

Suggested reviewers: ravitri, smg247

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: simplifying the InPlacePodVerticalScaling conformance skip regex.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only updates YAML TEST_SKIPS regexes; no Ginkgo test titles or dynamic test names were changed.
Test Structure And Quality	✅ Passed	Only ci-operator YAML TEST_SKIPS entries changed; no Ginkgo test code or test logic was modified, so the checklist is not applicable.
Microshift Test Compatibility	✅ Passed	PR only edits TEST_SKIPS regexes in CI YAML; no new Ginkgo tests or APIs/features were added to review for MicroShift.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only edits ci-operator TEST_SKIPS YAML; no new Ginkgo test definitions or SNO-sensitive code paths were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only TEST_SKIPS regexes changed in CI config/workflow YAML; no scheduling manifests, controllers, or topology constraints were introduced.
Ote Binary Stdout Contract	✅ Passed	PR only updates YAML TEST_SKIPS entries; no process-level binary code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only TEST_SKIPS regexes changed in YAML config; no new Ginkgo tests or networking logic were added.
No-Weak-Crypto	✅ Passed	Diff only removes an over-specific test-skip regex; no weak crypto, custom crypto, or secret comparisons appear in the changed files.
Container-Privileges	✅ Passed	Only TEST_SKIPS regexes changed in YAML configs/workflow; no privileged, hostPID, hostNetwork, hostIPC, allowPrivilegeEscalation, or SYS_ADMIN fields were added.
No-Sensitive-Data-In-Logs	✅ Passed	Only TEST_SKIPS regexes changed; no logging calls or sensitive data were added in the modified files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

The skip pattern `InPlacePodVerticalScaling.*decrease memory limit below usage` never matched because in the actual test name the text `decrease memory limit below usage` appears before the `[Feature:InPlacePodVerticalScaling]` tag. Simplify to just `decrease memory limit below usage` which matches unambiguously.

openshift-merge-bot · 2026-07-23T18:05:57Z

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-4.19-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

dustman9000 · 2026-07-23T18:07:14Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn

openshift-merge-bot · 2026-07-23T18:07:17Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-07-24T17:46:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/release/OWNERS~~ [petr-muller]
~~ci-operator/step-registry/rosa/aws/hcp/conformance/OWNERS~~ [dustman9000,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dustman9000 · 2026-07-24T22:49:02Z

/pj-rehearse ack

openshift-merge-bot · 2026-07-24T22:49:06Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-07-24T23:03:31Z

@dustman9000: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from ravitri and smg247 July 23, 2026 17:42

dustman9000 force-pushed the fix-conformance-skip-regex branch from 473fd3b to 2030ab2 Compare July 23, 2026 18:02

petr-muller approved these changes Jul 24, 2026

View reviewed changes

openshift-ci Bot assigned petr-muller Jul 24, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 24, 2026

openshift-merge-bot Bot merged commit 1775799 into openshift:main Jul 24, 2026
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix InPlacePodVerticalScaling conformance skip regex#82369

Fix InPlacePodVerticalScaling conformance skip regex#82369
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dustman9000:fix-conformance-skip-regex

dustman9000 commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

dustman9000 commented Jul 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

dustman9000 commented Jul 24, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 24, 2026

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dustman9000 commented Jul 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Fix

Affected files

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

dustman9000 commented Jul 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

dustman9000 commented Jul 24, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 24, 2026

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dustman9000 commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading