NO-JIRA: Fix sippy staging HATEOAS links by preserving Host header

[smg247]

Add ProxyPreserveHost On to the httpd reverse proxy config so the original Host header is forwarded to sippy's backend. Without this, Apache rewrites the Host to localhost:8080, causing GetBaseURL() to return the internal address instead of the tunnel URL.

Summary by CodeRabbit

Updates the sippy staging Apache reverse proxy to preserve the original Host header, ensuring backend-generated HATEOAS links use the tunnel URL instead of localhost:8080.

[openshift-ci-robot]

@smg247: This pull request explicitly references no jira issue.

Details

In response to this:

Add ProxyPreserveHost On to the httpd reverse proxy config so the original Host header is forwarded to sippy's backend. Without this, Apache rewrites the Host to localhost:8080, causing GetBaseURL() to return the internal address instead of the tunnel URL.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 690d4884-5724-48c5-a9ba-d35f14adbcb4

📥 Commits

Reviewing files that changed from the base of the PR and between b01f46a and 4e6f84b.

📒 Files selected for processing (1)

• ci-operator/step-registry/sippy-staging/deploy/sippy-staging-deploy-commands.sh

---

Walkthrough

The Sippy staging deployment script now adds ProxyPreserveHost On to the generated Apache reverse proxy configuration, preserving the incoming tunnel host when forwarding requests to Sippy.

Changes

Sippy staging proxy

Layer / File(s)	Summary
Preserve incoming proxy host ci-operator/step-registry/sippy-staging/deploy/sippy-staging-deploy-commands.sh	The generated Apache configuration preserves the incoming Host header when proxying to localhost:8080.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: amp-rh

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: preserving the Host header to fix Sippy staging HATEOAS links.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only adds Apache ProxyPreserveHost config in a shell script; no Ginkgo test titles were added or modified, so there are no unstable names to flag.
Test Structure And Quality	✅ Passed	PR only changes an httpd shell config file; no Ginkgo tests or test patterns are introduced or modified.
Microshift Test Compatibility	✅ Passed	Patch only updates an httpd proxy script; no new Ginkgo e2e tests or test APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only an httpd proxy shell script changed; no new Ginkgo e2e test or multi-node/SNO assumption was added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only httpd proxy header handling changed; no replicas, affinity, node selectors, PDBs, or topology-aware scheduling constraints were added.
Ote Binary Stdout Contract	✅ Passed	PR only adds ProxyPreserveHost in a shell-based httpd config; no process-level stdout writes or binary startup code were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only updates Apache proxy config; no Ginkgo e2e tests, IP parsing, or external connectivity changes are present.
No-Weak-Crypto	✅ Passed	Diff only adds ProxyPreserveHost On to Apache config; no weak-crypto, custom crypto, or secret-comparison code appears in the change.
Container-Privileges	✅ Passed	Touched file only adds ProxyPreserveHost in an httpd config; no privileged/container settings were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The patch only adds ProxyPreserveHost and a comment; it doesn't add or alter any logging of secrets, PII, or internal data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@smg247: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-sippy-main-agentic-staging	openshift/sippy	presubmit	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[smg247]

/pj-rehearse pull-ci-openshift-sippy-main-agentic-staging

[openshift-merge-bot]

@smg247: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[smg247]

/pj-rehearse ack

[openshift-merge-bot]

@smg247: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[neisw]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/sippy-staging/deploy/OWNERS [neisw,smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment