Skip to content

Move gcp-hcp-infra presubmits to AWS build farm for WIF (1/2)#82382

Draft
jimdaga wants to merge 1 commit into
openshift:mainfrom
jimdaga:feature/GCP-554-job-dispatch
Draft

Move gcp-hcp-infra presubmits to AWS build farm for WIF (1/2)#82382
jimdaga wants to merge 1 commit into
openshift:mainfrom
jimdaga:feature/GCP-554-job-dispatch

Conversation

@jimdaga

@jimdaga jimdaga commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves openshift-online-gcp-hcp-infra-main-presubmits.yaml from buildFarm.gcp (build08) to buildFarm.aws.build01 and adds platform-gcp: aws to cloudMapping.

Why

WIF authentication requires AWS build clusters with public OIDC endpoints. GCP/vSphere clusters (build02, 04, 08) use https://kubernetes.default.svc as their OIDC issuer, which is not publicly accessible — GCP STS cannot verify tokens from those clusters.

Changes

  • core-services/sanitize-prow-jobs/_config.yaml:
    • Move presubmits filename from buildFarm.gcp.build08 to buildFarm.aws.build01
    • Add platform-gcp: aws to cloudMapping for future job files

This is step 1 of 2 — the step registry and ci-operator config follow in a separate PR after this merges.

Jira: GCP-554, GCP-555

Test plan

  • CI checks pass
  • Generated jobs show AWS cluster assignments after merge

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Moves the OpenShift Online GCP HCP infrastructure presubmit jobs to the AWS build01 cluster, enabling WIF authentication through its publicly accessible OIDC endpoint.
  • Maps the platform-gcp platform to AWS in sanitize-prow-jobs configuration.

Move openshift-online-gcp-hcp-infra-main-presubmits.yaml from
buildFarm.gcp (build08) to buildFarm.aws.build01. WIF requires
AWS build clusters with public OIDC endpoints — GCP/vSphere
clusters (build02, 04, 08) use https://kubernetes.default.svc
which is not publicly accessible for GCP STS token validation.

Also add platform-gcp to cloudMapping so future job files
(periodics, postsubmits) route to AWS clusters automatically.

Part of GCP-554 / GCP-555.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 24, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jimdaga: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jimdaga
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 837af590-b95f-465c-8c48-208ac302f61b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The sanitize-prow-jobs configuration moves a presubmit filename within the aws.build01.filenames list and adds platform-gcp: aws to cloudMapping.

Changes

Sanitize Prow jobs

Layer / File(s) Summary
Filename and cloud mapping updates
core-services/sanitize-prow-jobs/_config.yaml
Moves openshift-online-gcp-hcp-infra-main-presubmits.yaml within the filename list and maps platform-gcp to aws.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: dustman9000

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: moving the presubmits to the AWS build farm for WIF.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only core-services/sanitize-prow-jobs/_config.yaml changed; no test files or Ginkgo titles were modified.
Test Structure And Quality ✅ Passed PR only edits core-services/sanitize-prow-jobs/_config.yaml; no Ginkgo test code or cluster-interaction tests were changed, so the check is not applicable.
Microshift Test Compatibility ✅ Passed Only core-services/sanitize-prow-jobs/_config.yaml changed; no Ginkgo tests or MicroShift-sensitive APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR only re-routes an existing presubmit YAML between build clusters; no new Ginkgo tests or test bodies were added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only core-services/sanitize-prow-jobs/_config.yaml changed; it reassigns a prow job filename and cloudMapping, with no manifests/controllers or pod scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR only edits sanitize-prow-jobs YAML mappings; no process-level code or stdout writes were added or changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only edits sanitize-prow-jobs YAML mapping; no Ginkgo e2e tests or network logic were added.
No-Weak-Crypto ✅ Passed PR only reorders a YAML filename list and adds cloudMapping; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret-compare code is present.
Container-Privileges ✅ Passed PASS: The diff only changes job placement metadata; no manifest in the PR sets privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed Only a YAML job-routing config changed; no logging code or sensitive literals (passwords, tokens, PII, hostnames) were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jimdaga

jimdaga commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@jimdaga

jimdaga commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@jimdaga: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant