setup assisted-installer version v2.55#82441
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
WalkthroughAdds v2.55 CI Operator configurations for assisted-image-service, assisted-installer-agent, assisted-installer, and assisted-service, including pinned builds, image promotion, resource defaults, validation jobs, and scenario-specific end-to-end workflows. ChangesAssisted v2.55 CI pipelines
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
A total of 53 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml (1)
70-74: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueOptional: align cache env with the sibling steps.
The
teststep below (Lines 81-82) and the agent/installer lint steps useGOCACHE=/tmp/gocacheplusGOMODCACHE=/tmp/gomodcache; this step only setsGOCACHE=/tmp/. Harmless if it currently passes, but the inconsistency is easy to remove.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml` around lines 70 - 74, Align the cache environment in the lint command block with the sibling test and agent/installer lint steps by setting GOCACHE to /tmp/gocache and adding GOMODCACHE=/tmp/gomodcache, while preserving the existing GOPROXY and make lint commands.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml`:
- Around line 190-194: Remove the always_run field from the
e2e-metal-assisted-lvm job configuration, leaving run_if_changed and the
existing job settings unchanged so execution remains conditional on matching
changes.
---
Nitpick comments:
In
`@ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml`:
- Around line 70-74: Align the cache environment in the lint command block with
the sibling test and agent/installer lint steps by setting GOCACHE to
/tmp/gocache and adding GOMODCACHE=/tmp/gomodcache, while preserving the
existing GOPROXY and make lint commands.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: e9e494eb-4c2b-41d3-99a1-19fb4fccf524
⛔ Files ignored due to path filters (8)
ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yamlci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml
| - always_run: true | ||
| as: e2e-metal-assisted-lvm | ||
| capabilities: | ||
| - intranet | ||
| run_if_changed: ^(internal/operators/[^/]+\.go|internal/operators/lvm/.*|internal/operators/api/.*|internal/operators/handler/.*)$ |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# How do other assisted-service branch configs configure e2e-metal-assisted-lvm?
fd -t f 'openshift-assisted-service-.*\.yaml' ci-operator/config/openshift/assisted-service \
--exec sh -c 'echo "== $1"; rg -n -B2 -A4 "as: e2e-metal-assisted-lvm" "$1"' sh {}Repository: openshift/release
Length of output: 8994
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect local references to Prow semantics and the same job pattern elsewhere.
rg -n --hidden -S 'always_run: true|run_if_changed:' \
ci-operator/config/openshift/assisted-service \
.github . 2>/dev/null | sed -n '1,220p'
printf '\n--- prow docs refs ---\n'
rg -n --hidden -S 'run_if_changed|always_run' \
docs hack pkg test . 2>/dev/null | sed -n '1,220p'Repository: openshift/release
Length of output: 46339
🌐 Web query:
Prow presubmit always_run run_if_changed semantics docs
💡 Result:
In Prow, the configuration parameters always_run and run_if_changed define how and when presubmit jobs are triggered for pull requests [1][2]. These parameters are mutually exclusive; a job should typically use one or the other, but not both [3][4]. always_run When set to true, the job is classified as one that runs unconditionally and automatically for every pull request [1][2]. Prow will trigger this job every time a PR is opened or updated [3]. run_if_changed When provided with a regular expression, the job is classified as one that runs conditionally and automatically [1][2]. Prow evaluates the changed files in the pull request against this regular expression [1][2]. If any changed file matches the pattern, the job is triggered [1][3]. If no changed files match, the job is skipped [1][3]. Semantics and Categorization Prow categorizes presubmit jobs into three distinct types based on these configurations [1][2]: 1. Unconditional/Automatic: Jobs with always_run: true [1][2]. 2. Conditional/Automatic: Jobs with run_if_changed (or skip_if_only_changed) configured [1][2]. 3. Conditional/Manual: Jobs with always_run: false that do not specify run_if_changed or skip_if_only_changed. These jobs require a human to trigger them manually via a comment command (e.g., /test ) [1][2][3]. If neither always_run nor a conditional filter (run_if_changed/skip_if_only_changed) is configured, the job defaults to the manual category [1][2]. Using both always_run: true and run_if_changed simultaneously is considered a misconfiguration [4].
Citations:
- 1: https://docs.prow.k8s.io/docs/jobs/
- 2: https://github.com/kubernetes-sigs/prow/blob/main/site/content/en/docs/jobs.md
- 3: https://github.com/nephio-project/nephio-test-prow-project
- 4: Tide categorising passing PRs using run_if_changed and run_after_success as 'prs-missing' kubernetes/test-infra#8133
Remove always_run here — run_if_changed already makes e2e-metal-assisted-lvm conditional; Prow treats these fields as mutually exclusive, so always_run is dead config.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml`
around lines 190 - 194, Remove the always_run field from the
e2e-metal-assisted-lvm job configuration, leaving run_if_changed and the
existing job settings unchanged so execution remains conditional on matching
changes.
|
@danmanor: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing as duplicate of #82453 |
2 participants
Summary by CodeRabbit
Adds generated CI Operator configurations for the assisted-installer, assisted-installer-agent, assisted-image-service, and assisted-service repositories targeting version
v2.55.The configurations pin component images and build outputs to
v2.55, configure image promotion and nightly release candidates, and add or update lint, unit, subsystem, mirror, and platform-specific end-to-end testing across bare-metal, OCI, AWS, vSphere, and specialized deployment scenarios.