Skip to content

Re-add rhacs-operator to OPP 5.0 upgrade config - #82918

Closed
amp-rh wants to merge 1 commit into
openshift:mainfrom
amp-rh:add-rhacs-5.0-upgrade
Closed

Re-add rhacs-operator to OPP 5.0 upgrade config#82918
amp-rh wants to merge 1 commit into
openshift:mainfrom
amp-rh:add-rhacs-5.0-upgrade

Conversation

@amp-rh

@amp-rh amp-rh commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Re-adds rhacs-operator to the OPP 5.0 upgrade job config after it reappeared in the OCP 5.0 redhat-operators catalog (July 31 sync)
  • Uses stable channel (head: v4.11.2) with operator_group field to ensure proper OperatorGroup creation
  • odf-operator remains excluded until published to the 5.0 catalog (tracked by RHSTOR-8660)

Context

PR #82372 removed rhacs-operator and odf-operator from the 5.0 upgrade config because they were absent from the catalog when authored (~July 23). The catalog has since been populated and rhacs-operator is now available. The package-level deprecated: true flag is metadata-only (the stable channel and its head bundle are not deprecated).

/cc @MPruitt

Summary by CodeRabbit

  • Re-adds rhacs-operator to the OPP 5.0 upgrade job.
  • Configures the stable channel, v4.11.2 starting version, and operator_group.
  • Keeps odf-operator excluded until publication to the 5.0 catalog.

@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@amp-rh: GitHub didn't allow me to request PR reviews from the following users: mpruitt.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Summary

  • Re-adds rhacs-operator to the OPP 5.0 upgrade job config after it reappeared in the OCP 5.0 redhat-operators catalog (July 31 sync)
  • Uses stable channel (head: v4.11.2) with operator_group field to ensure proper OperatorGroup creation
  • odf-operator remains excluded until published to the 5.0 catalog (tracked by RHSTOR-8660)

Context

PR #82372 removed rhacs-operator and odf-operator from the 5.0 upgrade config because they were absent from the catalog when authored (~July 23). The catalog has since been populated and rhacs-operator is now available. The package-level deprecated: true flag is metadata-only (the stable channel and its head bundle are not deprecated).

/cc @MPruitt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 96370319-aeaf-49fa-a51d-740f6538abfc

📥 Commits

Reviewing files that changed from the base of the PR and between f34bc05 and f0b6c43.

📒 Files selected for processing (1)
  • ci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp5.0-upgrade.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp5.0-upgrade.yaml

Walkthrough

The OCP 5.0 upgrade configuration adds the rhacs-operator with stable-channel settings, a dedicated installation namespace, an empty target namespace, and an operator group.

Changes

RHACS operator upgrade

Layer / File(s) Summary
Configure RHACS operator installation
ci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp5.0-upgrade.yaml
The upgrade workflow adds rhacs-operator with the stable channel, rhacs-operator installation namespace, empty target namespace, and operator group.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the re-addition of rhacs-operator to the OPP 5.0 upgrade configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies only a CI-operator YAML configuration file, not Ginkgo test files. No test names are added or modified, so the stability check does not apply.
Test Structure And Quality ✅ Passed The pull request modifies only a CI/CD configuration YAML file. It contains no Ginkgo test code, making the test structure and quality check not applicable to this PR.
Microshift Test Compatibility ✅ Passed The PR changes only one YAML operator declaration and adds no Ginkgo e2e tests or test-related source files, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The change only modifies a YAML CI configuration file to add rhacs-operator to the operator installation list. The SNO Test Compatibility check applies...
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only the OPERATORS JSON entry; it adds no deployment manifest, controller code, replica policy, affinity, topology spread, node selector, toleration, or PDB constraint.
Ote Binary Stdout Contract ✅ Passed PR modifies only a YAML CI configuration file with no executable code. OTE Binary Stdout Contract applies to test binaries and process-level code, not configuration data.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only a YAML CI configuration file and does not add any Ginkgo e2e tests. The custom check applies only to new Ginkgo e2e tests and is not applicable here.
No-Weak-Crypto ✅ Passed The PR changes only one YAML operator entry; scans of the added line and changed file found no weak-crypto algorithms, crypto code, or secret comparisons.
Container-Privileges ✅ Passed The one-line change adds only OPERATORS metadata; the entry contains no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation fields.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds one non-sensitive OPERATORS entry; the diff adds no logging code or credentials, and install-operators documents OPERATORS as installation input.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amp-rh
Once this PR has been reviewed and has the lgtm label, please assign justinkuli for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amp-rh

amp-rh commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Re-adds rhacs-operator to the OPP 5.0 upgrade job config after it
reappeared in the OCP 5.0 redhat-operators catalog (July 31 sync).

Uses stable channel (head: v4.11.2) with operator_group and empty
target_namespaces to create an AllNamespaces OperatorGroup, matching
the operator's supported install mode.

odf-operator remains excluded until published to the 5.0 catalog
(tracked by RHSTOR-8660, expected ~Nov 2026).
@amp-rh
amp-rh force-pushed the add-rhacs-5.0-upgrade branch from 9e68a2f to f0b6c43 Compare August 5, 2026 14:56
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@amp-rh

amp-rh commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #82920 which now includes the rhacs-operator install line (with AllNamespaces fix). Combining into a single PR to avoid merge conflicts and ensure atomic validation.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@amp-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-stolostron-policy-collection-main-ocp5.0-upgrade-interop-opp-upgrade-aws N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant