INTEROP-9415: Remove non-interop test steps from OPP CI configs - #83356
INTEROP-9415: Remove non-interop test steps from OPP CI configs#83356amp-rh wants to merge 1 commit into
Conversation
|
@amp-rh: This pull request references INTEROP-9415 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@amp-rh: GitHub didn't allow me to request PR reviews from the following users: CSPI-QE. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
Included review availability: Your plan includes up to 2 reviews per rolling hour; 1 remains after this review. WalkthroughThe policy-collection configurations for OCP 4.22, 5.0, and 5.1 remove obsolete base images, test environment variables, and interop test references from AWS and vSphere jobs. ChangesInterop configuration cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR removes non-interop CI steps and their orphaned configuration without changing the remaining interop coverage; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amp-rh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse skip |
|
@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/cc @cspi-qe-ocp-lp |
d7f6f9e to
3aea51b
Compare
|
@amp-rh: |
3aea51b to
4f83222
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@amp-rh, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@amp-rh: This pull request references INTEROP-9415 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Blocker: GitHub API outage (2026-08-17) ci/prow/check-gh-automation failing on all openshift/release PRs due to GitHub returning HTTP 503 to Prow permission checks. See https://www.githubstatus.com/. Unrelated to PR changes; will pass on /retest once GitHub recovers. |
|
/retest |
Remove acm-tests-grc, acm-tests-alc, and openshift-extended-test from OPP interop job configurations across OCP 4.22, 5.0, and 5.1. These single-product test steps don't meet the interop definition and are already validated by each product's own CI: - acm-tests-grc: pure ACM GRC policy testing (stolostron CI) - acm-tests-alc: pure ACM UI lifecycle testing (stolostron CI) - openshift-extended-test: pure OCP Cluster_Observability (OCP CI) Also removes orphaned base_images (acmqe-grc-test, console-e2e, tests-private) and env vars (TEST_IMPORTANCE, TEST_SCENARIOS) that only served the removed steps. INTEROP-9415
4f83222 to
b1fdc90
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@amp-rh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Friendly ping for review. This PR removes non-interop test steps (acm-tests-grc, acm-tests-alc, openshift-extended-test) from OPP CI configs per the interop-only realignment (INTEROP-9323). Looking for /lgtm + /approve from a cspi-qe-ocp-lp team member. Thanks! |
TL;DR
Pure deletion PR: removes 3 non-interop test steps and their orphaned dependencies from all 6 OPP interop jobs. No new code, no behavior changes to remaining steps. Each removed step is already validated by its product's own CI.
Why This Change
OPP interop jobs exist to validate that ACM, ACS, ODF, and Quay work together on a shared OCP cluster. Three of the test steps in the current pipeline do not test any cross-product behavior:
acm-tests-grcacm-tests-alcopenshift-extended-testThese steps add runtime (the
openshift-extended-teststep alone can take 30-60 minutes) and introduce failure modes unrelated to interop. When they fail, they generate Firewatch tickets that require triage time to classify as "not an interop issue," diluting the signal-to-noise ratio of the pipeline.These steps were evaluated and confirmed to have zero dependency on or interaction with ACS, ODF, or Quay APIs, services, or state. They pass identically on clusters with and without the other OPP products installed.
Removing them reduces job runtime, eliminates false-positive Firewatch tickets from non-interop test failures, and sharpens the pipeline's focus on cross-product validation. All interop-relevant steps (policy deployment via
acm-policies-openshift-plus, CLC cluster creation, OPP app lifecycle, observability for OPP-specific scenarios) remain.What changed
Steps removed from
test:sections:acm-tests-grcacm-tests-alcopenshift-extended-testOrphaned config also removed:
base_imagesacmqe-grc-test,console-e2e,tests-privatefrom:field in step refs)envvarsTEST_IMPORTANCE,TEST_SCENARIOSopenshift-extended-testReview guide
All 3 files have identical removals (symmetric across OCP versions). Reviewing one file covers the full change. Start with:
Core file (review this, the other two are identical):
ci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp4.22.yaml(-20 lines)Confirm-identical files:
stolostron-policy-collection-main__ocp5.0.yaml(-20 lines)stolostron-policy-collection-main__ocp5.1.yaml(-20 lines)What stays
All interop-relevant steps remain:
acm-policies-openshift-plus,acm-tests-clc-create,acm-opp-app,interop-tests-ocs-tests,quay-tests-quay-interop-test,acm-tests-observability, and the install/health-check chains.Risk areas
IGNORE_SECONDARY_POLICIESenv var is NOT removed; it's consumed byacm-policies-openshift-plus(not by any removed step).clc-ui-e2ebase image is NOT removed; it's consumed byacm-tests-clc-create.make updatechanges needed (step refs resolved at runtime by ci-operator).Testing
test:sections before/after.base_imageshave no other consumers in these configs.Jira
Part of OPP Q3 interop improvements (umbrella: #83405).
Summary by CodeRabbit
This PR updates six OPP interop jobs for OCP 4.22, 5.0, and 5.1. It removes the non-interop
acm-tests-grc,acm-tests-alc, andopenshift-extended-teststeps from the AWS and vSphere workflows.It also removes the unused
acmqe-grc-test,console-e2e, andtests-privatebase images, plus theTEST_IMPORTANCEandTEST_SCENARIOSenvironment variables. Remaining interop steps are unchanged.Rehearsal validation
Steps in this PR: Removal of 3 non-interop test steps from CI configs
Validated via structural CI checks and the combined batch PR (#83405) rehearsals.
This PR removes step references from ci-operator configs. No new steps are introduced. Validation is through structural CI checks (ci-operator-config, ci-operator-registry, step-registry-metadata) and the batch PR's rehearsals, which run the updated pipeline without the removed steps.
Rehearsal ack rationale: All rehearsal failures are caused by known infrastructure issues (ACS upstream scanner timeout, ACM S3 credential rotation) unrelated to this PR's changes. All structural CI checks (ci-operator-config, ci-operator-registry, step-registry-shellcheck, yamllint, generated-config) pass. See batch PR #83405 for full rehearsal results and analysis.