Skip to content

NO-JIRA: fix: have devspace.yaml call backend directly to pass -features flag - #264

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
alanconway:devspace-fix
Aug 5, 2026
Merged

NO-JIRA: fix: have devspace.yaml call backend directly to pass -features flag#264
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
alanconway:devspace-fix

Conversation

@alanconway

@alanconway alanconway commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The devspace image is too old to have the Makefile FEATURES variable,
skip make and run the backend directly for devspace.

Summary by CodeRabbit

  • Chores
    • Improved development environment startup and initial synchronization visibility by adjusting sync settings.
    • Updated the development backend launch configuration to use an explicit command with port, TLS certificate/key, plugin configuration, and static-content and config paths.
    • Enabled the agent-navigation capability in the development environment.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Walkthrough

The DevSpace configuration changes sync behavior and backend startup. It keeps startup and initial sync logging. It removes sync exclusions and upload restart behavior. It starts plugin-backend directly with explicit runtime arguments.

Changes

DevSpace runtime update

Layer / File(s) Summary
Sync and backend startup
devspace.yaml
The dev container sync keeps startup and initial sync logging, removes path exclusions and upload restart behavior, and starts plugin-backend directly with explicit HTTPS, TLS, config, static path, and agent-navigation arguments.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: jgbernalp, peteryurkovich

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR only modifies devspace.yaml and does not change any Ginkgo test files. The check is not applicable to this PR's scope.
Test Structure And Quality ✅ Passed The PR changes only devspace.yaml. It adds or modifies no Ginkgo tests, so the listed Ginkgo test-quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The PR only modifies devspace.yaml for development container configuration. The MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only devspace.yaml and does not add any Ginkgo e2e tests (It(), Describe(), Context(), When(), etc.), so the SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The only changed file is devspace.yaml; it changes the development container command and sync settings, and adds no scheduling constraints or topology assumptions.
Ote Binary Stdout Contract ✅ Passed PR modifies only devspace.yaml configuration file; no Go code changes. OTE Binary Stdout Contract check applies to Go process-level code stdout writes, not YAML configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only devspace.yaml and adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity test requirements.
No-Weak-Crypto ✅ Passed The PR only modifies devspace.yaml, a configuration file that does not implement or reference weak cryptographic algorithms (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto, or non-constan...
Container-Privileges ✅ Passed The devspace.yaml changes do not introduce privileged container settings, hostPID/Network/IPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation=true. The Kubernetes deployment template enforces...
No-Sensitive-Data-In-Logs ✅ Passed The devspace.yaml changes pass file paths and feature flags only, not sensitive data like passwords, tokens, or API keys. TLS certificate/key locations are referenced by path, not embedded inline.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: running the backend directly from devspace.yaml to pass the -features flag.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@PeterYurkovich

Copy link
Copy Markdown
Contributor

I think we should handle this in a different way. Either

  1. Rebuild the devspace image and point to the new image
  2. Make a start up action that builds the go backend and then syncs the newly build binary into the container. This wouldn't work for backend development (we would need something like gow or air to watch for changes and rebuild) but it would at least make sure that the backend you are running in the cluster is up to date. Doesn't fix the makefile issue though, so we probably still need to rebuild the image

@PeterYurkovich

Copy link
Copy Markdown
Contributor

That being said, not really a huge priority. Can be done in a follow up pr if need be

@PeterYurkovich

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
- get rid of bogus excludes and restart, causing errors
- have devspace.yaml call backend directly to pass -features flag
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
@PeterYurkovich

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,alanconway]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
@alanconway alanconway changed the title fix: have devspace.yaml call backend directly to pass -features flag NO-JIRA: fix: have devspace.yaml call backend directly to pass -features flag Aug 5, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@alanconway: This pull request explicitly references no jira issue.

Details

In response to this:

The devspace image is too old to have the Makefile FEATURES variable,
skip make and run the backend directly for devspace.

Summary by CodeRabbit

  • Chores
  • Improved development environment startup and initial synchronization visibility by adjusting sync settings.
  • Updated the development backend launch configuration to use an explicit command with port, TLS certificate/key, plugin configuration, and static-content and config paths.
  • Enabled the agent-navigation capability in the development environment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alanconway

Copy link
Copy Markdown
Contributor Author

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Aug 5, 2026
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown

@alanconway: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit ff0179e into openshift:main Aug 5, 2026
6 checks passed
@alanconway
alanconway deleted the devspace-fix branch August 5, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants