NO-JIRA: fix: have devspace.yaml call backend directly to pass -features flag - #264
Conversation
WalkthroughThe DevSpace configuration changes sync behavior and backend startup. It keeps startup and initial sync logging. It removes sync exclusions and upload restart behavior. It starts ChangesDevSpace runtime update
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
I think we should handle this in a different way. Either
|
|
That being said, not really a huge priority. Can be done in a follow up pr if need be |
|
/lgtm |
- get rid of bogus excludes and restart, causing errors - have devspace.yaml call backend directly to pass -features flag
a4697c5 to
24a45eb
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanconway, PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alanconway: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label qe-approved |
|
@alanconway: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The devspace image is too old to have the Makefile FEATURES variable,
skip make and run the backend directly for devspace.
Summary by CodeRabbit
agent-navigationcapability in the development environment.