Merged
Conversation
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
lmilleri
requested changes
Feb 27, 2026
lmilleri
reviewed
Feb 27, 2026
lmilleri
left a comment
lmilleri
left a comment
There was a problem hiding this comment.
What happens with different service types, e.g. ClusterIp or NodePort. Does the route need to change?
When Trustee is started, if there is no existing route, create a passthrough when restrictive mode and the https certs are given, otherwise create an edge one. Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Author
Theoretically this should not be tied to the service type, but I am not sure. When you use NodePort or ClusterIp, how do you connect with the Trustee? you need a route anyways right? |
|
@esposem LGTM thanks! |
lmilleri
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Trustee is started, if there is no existing route, create a passthrough when restrictive mode and the https certs are given, otherwise create an edge one.