Skip to content

feat: premarket by stryke#932

Merged
lorenz234 merged 2 commits intoopensource-observer:mainfrom
Aercwarden:patch-1
Apr 1, 2026
Merged

feat: premarket by stryke#932
lorenz234 merged 2 commits intoopensource-observer:mainfrom
Aercwarden:patch-1

Conversation

@Aercwarden
Copy link
Copy Markdown
Contributor

No description provided.

@ccerv1
Copy link
Copy Markdown
Member

ccerv1 commented Jan 17, 2026

Issues found:

  1. Missing GitHub URLs: The project has no GitHub repositories listed. At least one github URL is strongly recommended for inclusion in the OSS Directory. Does PreMarket have any open source repositories?

  2. Relationship to existing Stryke project: There's already a stryke-xyz project in the directory. Since your PR title indicates "premarket by stryke", should this be:

    • A separate project (current approach), OR
    • Added as additional repos to the existing stryke-xyz project?
  3. Description is too long: Please condense to 1-2 sentences focusing on the core value proposition.

Please clarify and update your PR.

@ccerv1 ccerv1 added the pr:changes_suggested PR has been reviewed with changes suggested label Jan 17, 2026
@Aercwarden
Copy link
Copy Markdown
Contributor Author

Will update

@lorenz234
Copy link
Copy Markdown
Collaborator

Thank you for your contribution, merging now, doesn't seem to have a github. @Aercwarden please add a github handle asap with another PR. thanks

@lorenz234 lorenz234 added this pull request to the merge queue Apr 1, 2026
Merged via the queue into opensource-observer:main with commit 241753d Apr 1, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:changes_suggested PR has been reviewed with changes suggested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants