Conversation
dd7da69 to
14119c3
Compare
2 tasks
Contributor
|
This works for me. As long as we get the build up and running again. I would however suggest adding the ruby version to the cache key: |
Our build and deploy workflow was using an outdated version of actions/cache that's no longer supported. That can be fixed by updating to actions/cache@v4. No interface changes are required in our YAML. We also need a way to make sure this works before merging the PR (if we don't want to debug a workflow after merge). The simplest way to do this is to extract our jekyll build steps into a github action. We can write a simple test workflow that just does a jekyll build, and we can use the same jekyll-build action in our existing deploy workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our build and deploy workflow was using an outdated version of actions/cache that's no longer supported. That can be fixed by updating to actions/cache@v4. No interface changes are required in our YAML.
We also need a way to make sure this works before merging the PR (if we don't want to debug a workflow after merge). The simplest way to do this is to extract our jekyll build steps into a github action. We can write a simple test workflow that just does a jekyll build, and we can use the same jekyll-build action in our existing deploy workflow.