Skip to content

Update actions/cache and Run Tests on PRs#68

Merged
mkasberg merged 1 commit intomasterfrom
test-workflow
Apr 25, 2026
Merged

Update actions/cache and Run Tests on PRs#68
mkasberg merged 1 commit intomasterfrom
test-workflow

Conversation

@mkasberg
Copy link
Copy Markdown
Collaborator

@mkasberg mkasberg commented Apr 25, 2026

Our build and deploy workflow was using an outdated version of actions/cache that's no longer supported. That can be fixed by updating to actions/cache@v4. No interface changes are required in our YAML.

We also need a way to make sure this works before merging the PR (if we don't want to debug a workflow after merge). The simplest way to do this is to extract our jekyll build steps into a github action. We can write a simple test workflow that just does a jekyll build, and we can use the same jekyll-build action in our existing deploy workflow.

@mkasberg mkasberg force-pushed the test-workflow branch 7 times, most recently from dd7da69 to 14119c3 Compare April 25, 2026 12:27
@mkasberg mkasberg changed the title Test Workflow Update actions/cache and Run Tests on PRs Apr 25, 2026
@mkasberg mkasberg marked this pull request as ready for review April 25, 2026 12:29
@JohnRDOrazio
Copy link
Copy Markdown
Contributor

JohnRDOrazio commented Apr 25, 2026

This works for me. As long as we get the build up and running again. I would however suggest adding the ruby version to the cache key:
the cache key is currently ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}. A Ruby ABI change (e.g. 3.2 → 3.4) with an unchanged Gemfile.lock would restore gems with native extensions compiled against the old Ruby — likely to crash at load. Expanded the key to hashFiles('**/Gemfile.lock', '.ruby-version') so future Ruby bumps invalidate the cache cleanly.

Our build and deploy workflow was using an outdated version of
actions/cache that's no longer supported. That can be fixed by updating
to actions/cache@v4. No interface changes are required in our YAML.

We also need a way to make sure this works before merging the PR (if we
don't want to debug a workflow after merge). The simplest way to do this
is to extract our jekyll build steps into a github action. We can write
a simple test workflow that just does a jekyll build, and we can use the
same jekyll-build action in our existing deploy workflow.
@mkasberg mkasberg merged commit ff6bb66 into master Apr 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants