Skip to content

[sushy_emulator] Fix list handling for VM instances#3678

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
holser:ansible-core-2.17.14_sushi
Mar 3, 2026
Merged

[sushy_emulator] Fix list handling for VM instances#3678
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
holser:ansible-core-2.17.14_sushi

Conversation

@holser
Copy link
Contributor

@holser holser commented Feb 12, 2026

  • Replace complex Jinja2 for-loop with idiomatic filter chain
    (dict2items | selectattr | map | list)
  • Remove regex_replace in favor of list in template
  • Keep variable as list for loop/index access in tasks

Co-authored-by: Cursor cursoragent@cursor.com
Signed-off-by: Sergii Golovatiuk sgolovat@redhat.com

@holser holser requested a review from rebtoor February 12, 2026 11:47
@holser holser force-pushed the ansible-core-2.17.14_sushi branch from d26f7a6 to 54cf81a Compare February 12, 2026 12:07
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/06565e38a53248ac9155519606efd3f4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 41s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 45s
cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 37m 03s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 24s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 57s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 06s
cifmw-molecule-reproducer FAILURE in 12m 12s
cifmw-molecule-sushy_emulator FAILURE in 18m 55s

@holser holser force-pushed the ansible-core-2.17.14_sushi branch from d79c2ac to 95eca9c Compare February 23, 2026 18:32
@holser holser force-pushed the ansible-core-2.17.14_sushi branch from 95eca9c to 2221d49 Compare February 23, 2026 18:36
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8836ee39b1574d0d98c28b131b7794d5

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 08s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 01s
cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 2h 07m 13s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 00s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 27m 37s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 26s
✔️ cifmw-molecule-reproducer SUCCESS in 16m 08s
✔️ cifmw-molecule-sushy_emulator SUCCESS in 19m 01s

@holser holser force-pushed the ansible-core-2.17.14_sushi branch 2 times, most recently from 449f48c to 2434a20 Compare February 24, 2026 18:10
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0ce7a2e60fa3444c9989ebe7fd09b9b1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 14s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 15m 01s
cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 14m 31s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 33s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 39s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 13s
cifmw-molecule-reproducer FAILURE in 12m 06s
cifmw-molecule-sushy_emulator TIMED_OUT in 32m 41s

@holser holser force-pushed the ansible-core-2.17.14_sushi branch from 2434a20 to 94dc1b7 Compare February 25, 2026 10:29
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/165f52543cb341c48ed2b46d63eb1630

✔️ openstack-k8s-operators-content-provider SUCCESS in 28m 38s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 11m 28s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 14m 06s
cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 15m 04s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 43s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 52s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 59s
cifmw-molecule-reproducer FAILURE in 15m 02s
cifmw-molecule-sushy_emulator FAILURE in 9m 46s

@holser
Copy link
Contributor Author

holser commented Feb 25, 2026

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fbeae082449646e885e12d4eeb4a803a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 37m 14s
podified-multinode-edpm-deployment-crc FAILURE in 1h 13m 18s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 37s
cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 2h 23m 34s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 00s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 28s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 38s
cifmw-molecule-reproducer FAILURE in 14m 50s
cifmw-molecule-sushy_emulator FAILURE in 9m 50s

@holser
Copy link
Contributor Author

holser commented Feb 25, 2026

From my local tests

TASK [sushy_emulator : Verify connection to baremetal VMs via Sushy Emulator url={{ _sushy_url }}/redfish/v1/Systems/{{item}}, return_content=True, user={{ cifmw_sushy_emulator_redfish_username }}, password={{ cifmw_sushy_emulator_redfish_password }}] ***
Wednesday 25 February 2026  16:45:35 +0100 (0:00:03.386)       1:48:45.289 ****
Wednesday 25 February 2026  16:45:35 +0100 (0:00:03.386)       1:48:45.288 ****
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=17a164e9-46af-504d-b750-4d768f4b1b71)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=a91fb6bc-1bf2-532a-b3ef-4bdecda8a0dd)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=8e6c659c-27df-5ead-bdf2-59b8dde77263)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=6cce038b-728b-567c-a123-3b18cc78126f)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=76e7119f-2a12-5cc1-b338-d40fa293369a)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=01d1202d-49f3-53ad-911c-e66103ebf64c)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=41e636ff-54e1-588d-b6c5-f5405b3f5f6b)

TASK [sushy_emulator : Verify baremetal VM power status quiet=True, that=['item.json.PowerState is defined']] ***************************************************************
Wednesday 25 February 2026  16:46:10 +0100 (0:00:34.944)       1:49:20.233 ****
Wednesday 25 February 2026  16:46:10 +0100 (0:00:34.944)       1:49:20.233 ****
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=cifmw-ocp-master-0)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=cifmw-ocp-master-1)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=cifmw-ocp-master-2)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=cifmw-compute-zx098j1n-0)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=cifmw-compute-zx098j1n-1)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=cifmw-compute-zx098j1n-2)
ok: [hypervisor -> controller-0(controller-0.hypervisor)] => (item=cifmw-controller-0)

Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.
The CI failures look unrelated.

@rebtoor
Copy link
Contributor

rebtoor commented Feb 25, 2026

recheck

Copy link
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/675a53eda2ba4ceb999203040df805a6

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 09s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 53s
cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 2h 09m 45s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 50s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 56s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 18s
cifmw-molecule-reproducer FAILURE in 13m 32s
✔️ cifmw-molecule-sushy_emulator SUCCESS in 29m 19s

@danpawlik
Copy link
Contributor

recheck

@danpawlik danpawlik force-pushed the ansible-core-2.17.14_sushi branch from 94dc1b7 to 79bd51e Compare February 26, 2026 12:29
@openshift-ci openshift-ci bot removed the lgtm label Feb 26, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

New changes are detected. LGTM label has been removed.

@holser
Copy link
Contributor Author

holser commented Feb 26, 2026

@danpawlik I provided the output of run of sushy_emulator role. The change creates data we need to run it properly.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/777530e62d6a464791e601802d12310e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 33m 56s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 26m 20s
cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 2h 06m 11s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 42s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 51s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 54s
cifmw-molecule-reproducer FAILURE in 14m 11s
cifmw-molecule-sushy_emulator FAILURE in 9m 54s

@holser holser force-pushed the ansible-core-2.17.14_sushi branch from 79bd51e to e0573c5 Compare February 26, 2026 16:50
@danpawlik
Copy link
Contributor

Let's see if that would fix molecule - #3720

danpawlik added a commit to danpawlik/ci-framework that referenced this pull request Feb 26, 2026
It can happen that the image used by the CRC has expired certificate,
so it require to approve new generated certificate before making test.

Depends-On: openstack-k8s-operators#3678

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik added a commit to danpawlik/ci-framework that referenced this pull request Feb 26, 2026
It can happen that the image used by the CRC has expired certificate,
so it require to approve new generated certificate before making test.

Depends-On: openstack-k8s-operators#3678

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik added a commit to danpawlik/ci-framework that referenced this pull request Feb 26, 2026
It can happen that the image used by the CRC has expired certificate,
so it require to approve new generated certificate before making test.

Depends-On: openstack-k8s-operators#3678

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fe7cb83ab33e4bed9ca85d58f90c0a6b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 45s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 40s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 14s
cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 2h 11m 36s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 49s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 46s
cifmw-molecule-reproducer FAILURE in 15m 59s
cifmw-molecule-sushy_emulator FAILURE in 9m 45s

- Replace complex Jinja2 for-loop with idiomatic filter chain
  (dict2items | selectattr | map | list)
- Remove regex_replace in favor of list in template
- Keep variable as list for loop/index access in tasks

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
@holser holser force-pushed the ansible-core-2.17.14_sushi branch from e0573c5 to f4bd241 Compare March 3, 2026 11:18
@holser holser requested a review from rebtoor March 3, 2026 11:24
@holser holser added the lgtm label Mar 3, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 4f13abf into openstack-k8s-operators:main Mar 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants