[reportportal]: avoid downloading the data router binary if it is already available#3713
[reportportal]: avoid downloading the data router binary if it is already available#3713srac0 wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @srac0. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
srac0
changed the title
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/01cd2e4d935d4336bc8bb5dcbbf23af0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 27m 13s |
…eady available These changes improve the performance of the role by avoiding downloading the data router at each call of the role. It is particularly important when calling it multiple times in the same job. Signed-off-by: Samuel Rac <srac@redhat.com>
srac0
force-pushed
the
dev/improve-perf-reportportal
branch
from
7e0d8f1 to
e627ec5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a4b60f4df74e4232959c5981520d754b ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 47s |
|
recheck |
michburk
left a comment
michburk
left a comment
There was a problem hiding this comment.
One comment to consider.
I'm not opposed to merging if people disagree 👍
| cifmw_reportportal_droute_binary) | | ||
| path_join | ||
| }} | ||
| _droute_dest: "{{ cifmw_reportportal_droute_dir }}/{{ cifmw_reportportal_droute_binary }}" |
There was a problem hiding this comment.
bit of a nit, but factoring _droute_dest out to the vars block for just this task could be improved. Since this path is used in two separate places, maybe you could factor out this path to a var with some name like cifmw_reportportal_droute_binary_dest and put this into roles/reportportal/defaults/main.yml. Then you could use this new var in both the Check if Data router client binary is already present task and this task (Get the Data router client).
3 participants
These changes improve the performance of the role by avoiding downloading the data router at each call of the role. It is particularly important when calling it multiple times in the same job.