Rabbitmq vhost and user support by lmiccini · Pull Request #1052 · openstack-k8s-operators/nova-operator

lmiccini · 2025-12-19T16:11:09Z

Add new messagingBus and notificationsBus interfaces to hold cluster, user and vhost names for optional usage.
The controller adds these values to the TransportURL create request when present.

Additionally, we migrate RabbitMQ cluster name to RabbitMq config struct using DefaultRabbitMqConfig from infra-operator to automatically populate the new Cluster field from legacy RabbitMqClusterName.

Example usage:

  spec:
    messagingBus:
      cluster: rpc-rabbitmq
      user: rpc-user
      vhost: rpc-vhost
    notificationsBus:
      cluster: notifications-rabbitmq
      user: notifications-user
      vhost: notifications-vhost

Jira: https://issues.redhat.com/browse/OSPRH-22697

Depends-on: openstack-k8s-operators/openstack-operator#1797

softwarefactory-project-zuul · 2025-12-19T19:50:02Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/190f4bb7eca7441d8e42567b23824058

✔️ openstack-meta-content-provider SUCCESS in 3h 29m 35s
✔️ nova-operator-kuttl SUCCESS in 42m 46s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 14m 56s
❌ nova-operator-tempest-multinode-ceph FAILURE in 2h 37m 49s

lmiccini · 2025-12-20T06:30:01Z

recheck

softwarefactory-project-zuul · 2025-12-20T09:51:44Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e49f704cb10943c295aeec1583a8186e

✔️ openstack-meta-content-provider SUCCESS in 3h 20m 36s
✔️ nova-operator-kuttl SUCCESS in 45m 29s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 48m 01s
❌ nova-operator-tempest-multinode-ceph FAILURE in 3h 00m 42s

lmiccini · 2025-12-20T13:38:01Z

recheck

softwarefactory-project-zuul · 2026-01-09T16:48:08Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/nova-operator for 1052,c449b78a627ef1b92bdfbe8b31c7e81728a983d5

api/v1beta1/nova_webhook.go

SeanMooney · 2026-01-09T17:47:52Z

test/kuttl/test-suites/default/nova-notificationsbus/01-deploy.yaml

+      cellDatabaseInstance: openstack
+      cellDatabaseAccount: nova-cell0
+      hasAPIAccess: true
+      memcachedInstance: memcached


so in this case we expect cell 0 to be using the the rabbitmq rabit cluster
based on teh default of CellMessageBusInstance in the cell template.

// +kubebuilder:validation:Optional // +kubebuilder:default=rabbitmq // CellMessageBusInstance is the name of the RabbitMqCluster CR to select // the Message Bus Service instance used by the nova services to // communicate in this cell. For cell0 it is unused. CellMessageBusInstance string `json:"cellMessageBusInstance"`

relying on the implict defaulting is nova very clear.

SeanMooney · 2026-01-09T17:55:32Z

test/kuttl/test-suites/default/nova-same-cluster/01-deploy.yaml

+  messagingBus:
+    cluster: rabbitmq
+  notificationsBus:
+    cluster: rabbitmq


while this is possibel to do that goes against best practices so this is nto somethin we shoudl supprot downstream

unlike with cells im ok with not blocking this in the webhook since it does not fundementally unermine how cells are desgien to work.

it generally recomemnted upstream for moderate to large clouds that each service uses its own rabbit instnace and notifications are kept sepreate form rpc trafic.

that using seperate notification really shoudl be the only deployment model we supprot downstream but its technially valid so we can supprot it in the operator. in a very small cloud i.e. less then 50 comptues its viable but its not somethign we shoudl ever default too or recommend for most clouds.

softwarefactory-project-zuul · 2026-01-09T23:55:48Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ca4ac87ba47c49098e4da429204a102a

✔️ openstack-meta-content-provider SUCCESS in 5h 06m 17s
❌ nova-operator-kuttl FAILURE in 43m 44s
❌ nova-operator-tempest-multinode FAILURE in 25m 44s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 46m 31s

openshift-ci · 2026-01-16T06:54:42Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lmiccini
Once this PR has been reviewed and has the lgtm label, please ask for approval from seanmooney. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

softwarefactory-project-zuul · 2026-01-16T07:19:30Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/nova-operator for 1052,d5bf4bf5e924abe3eb21fe46e34a7acf5ac27974

lmiccini · 2026-01-19T07:09:34Z

/test functional

softwarefactory-project-zuul · 2026-01-19T10:11:14Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/61a27248f6d44ffb9c3ef2fb8f54d1c2

✔️ openstack-meta-content-provider SUCCESS in 3h 13m 00s
❌ nova-operator-kuttl FAILURE in 45m 43s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 33m 30s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 49m 26s

softwarefactory-project-zuul · 2026-01-19T11:22:58Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c37d46757ba74c90bc5d68c446753ce7

✔️ openstack-meta-content-provider SUCCESS in 1h 00m 02s
❌ nova-operator-kuttl FAILURE in 42m 10s
❌ nova-operator-tempest-multinode FAILURE in 24m 34s
❌ nova-operator-tempest-multinode-ceph FAILURE in 21m 04s

softwarefactory-project-zuul · 2026-01-29T17:51:00Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d6214ce4dde54e78b263373c857bdcbe

❌ openstack-meta-content-provider FAILURE in 6m 50s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

lmiccini · 2026-01-29T17:54:47Z

recheck

softwarefactory-project-zuul · 2026-01-29T18:04:04Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/17055cd6ff87400794e6a86feee861ac

❌ openstack-meta-content-provider FAILURE in 7m 26s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

lmiccini · 2026-01-29T18:31:02Z

recheck

softwarefactory-project-zuul · 2026-01-29T18:40:03Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cef65f09fdcc4908af429ca5f7617228

❌ openstack-meta-content-provider FAILURE in 7m 32s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

softwarefactory-project-zuul · 2026-01-29T20:07:55Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e6c3bf90d07b4de2975a530265257caa

❌ openstack-meta-content-provider FAILURE in 7m 31s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

softwarefactory-project-zuul · 2026-01-30T15:57:43Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1df0f71b7ce84136bb6cbde9a4157791

❌ openstack-meta-content-provider FAILURE in 10m 42s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

lmiccini · 2026-01-30T21:23:38Z

recheck

auniyal61 · 2026-02-04T11:18:26Z

api/v1beta1/nova_webhook.go

+	if spec.MessagingBus.Cluster == "" {
+		spec.MessagingBus.Cluster = "rabbitmq"
+	}
+


should we have validation and default assigment incuded for spec.MessagingBus.user too

general question, so I am not sure why we need to update webhook to set this value here.

I thought webhook is for genral validation of var we set in CR's - like to restrict wrong conf and I generally use webhook to test my live code make run-with-webhook so that to provide pre-requisite
can you tell or @SeanMooney if around !

softwarefactory-project-zuul · 2026-02-05T07:24:37Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 1779,d0bba951fd942312b6e33713b2c686fed2fe5bf6

lmiccini · 2026-02-05T12:39:39Z

recheck

softwarefactory-project-zuul · 2026-02-05T12:55:05Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/493ddad7105949d181ad22f0b1220fef

❌ openstack-meta-content-provider FAILURE in 14m 04s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

lmiccini · 2026-02-05T13:04:50Z

recheck

Add new messagingBus and notificationsBus interfaces to hold cluster, user and vhost names for optional usage. The controller adds these values to the TransportURL create request when present. Additionally, we migrate RabbitMQ cluster name to RabbitMq config struct using DefaultRabbitMqConfig from infra-operator to automatically populate the new Cluster field from legacy RabbitMqClusterName. Example usage: spec: messagingBus: cluster: rpc-rabbitmq user: rpc-user vhost: rpc-vhost notificationsBus: cluster: notifications-rabbitmq user: notifications-user vhost: notifications-vhost Finally, we add the rabbitmquser crs to the secret so they can be stored for dataplane finalizers management and do auto cleanup of orphaned users after credential rotations. Jira: https://issues.redhat.com/browse/OSPRH-22697

softwarefactory-project-zuul · 2026-02-05T14:30:43Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1797 is needed.

lmiccini · 2026-02-05T14:30:59Z

recheck

lmiccini · 2026-02-05T14:32:11Z

/test functional

openshift-ci · 2026-02-05T14:37:57Z

@lmiccini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/precommit-check	`ebc58fb`	link	true	`/test precommit-check`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lmiccini · 2026-02-05T14:40:05Z

/test functional

softwarefactory-project-zuul · 2026-02-05T15:37:03Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/be6eb187439e41ce8a142ef3201d3578

✔️ openstack-meta-content-provider SUCCESS in 1h 04m 30s
✔️ nova-operator-kuttl SUCCESS in 46m 20s
❌ nova-operator-tempest-multinode FAILURE in 20m 41s
❌ nova-operator-tempest-multinode-ceph FAILURE in 24m 27s

lmiccini · 2026-02-05T15:46:36Z

recheck

lmiccini · 2026-02-05T17:35:18Z

recheck

softwarefactory-project-zuul · 2026-02-05T18:11:48Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1797 is needed.

lmiccini · 2026-02-05T18:12:15Z

recheck

lmiccini added the do-not-merge/work-in-progress label Dec 19, 2025

openshift-ci bot removed the do-not-merge/work-in-progress label Dec 19, 2025

openshift-ci bot requested review from stuggi and viroel December 19, 2025 16:11

lmiccini added the do-not-merge/hold label Dec 19, 2025

lmiccini force-pushed the rabbitmq_vhosts branch from 047781d to c449b78 Compare January 9, 2026 16:47

openshift-merge-robot added the needs-rebase label Jan 9, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from c449b78 to b5594d1 Compare January 9, 2026 17:53

openshift-merge-robot removed the needs-rebase label Jan 9, 2026

SeanMooney previously requested changes Jan 9, 2026

View reviewed changes

openshift-ci bot assigned SeanMooney Jan 9, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from b5594d1 to a55d41f Compare January 16, 2026 06:54

lmiccini force-pushed the rabbitmq_vhosts branch 2 times, most recently from f5fe07a to d5bf4bf Compare January 16, 2026 07:19

openshift-merge-robot added the needs-rebase label Jan 16, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from d5bf4bf to 95599f7 Compare January 19, 2026 06:56

openshift-merge-robot removed the needs-rebase label Jan 19, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from 95599f7 to 6c79605 Compare January 19, 2026 10:21

lmiccini force-pushed the rabbitmq_vhosts branch from 6c79605 to 72840d4 Compare January 19, 2026 11:29

lmiccini force-pushed the rabbitmq_vhosts branch from aff29e9 to 8130899 Compare January 29, 2026 19:58

lmiccini force-pushed the rabbitmq_vhosts branch from 8130899 to 145dc1d Compare January 30, 2026 15:45

lmiccini removed the do-not-merge/hold label Feb 2, 2026

auniyal61 reviewed Feb 4, 2026

View reviewed changes

lmiccini force-pushed the rabbitmq_vhosts branch from 145dc1d to 0fcbd76 Compare February 5, 2026 07:24

lmiccini added 2 commits February 5, 2026 15:05

Make deprecated parameter optional

ebc58fb

lmiccini force-pushed the rabbitmq_vhosts branch from 0fcbd76 to ebc58fb Compare February 5, 2026 14:24

Conversation

lmiccini commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Dec 19, 2025

Uh oh!

lmiccini commented Dec 20, 2025

Uh oh!

softwarefactory-project-zuul bot commented Dec 20, 2025

Uh oh!

lmiccini commented Dec 20, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jan 9, 2026

Uh oh!

Uh oh!

Uh oh!

SeanMooney Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

SeanMooney Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Jan 9, 2026

Uh oh!

openshift-ci bot commented Jan 16, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 16, 2026

Uh oh!

lmiccini commented Jan 19, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 19, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 19, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 29, 2026

Uh oh!

lmiccini commented Jan 29, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 29, 2026

Uh oh!

lmiccini commented Jan 29, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 29, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 29, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 30, 2026

Uh oh!

lmiccini commented Jan 30, 2026

Uh oh!

auniyal61 Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Feb 5, 2026

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 5, 2026

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 5, 2026

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

openshift-ci bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 5, 2026

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 5, 2026

Uh oh!

lmiccini commented Dec 19, 2025 •

edited

Loading

openshift-ci bot commented Feb 5, 2026 •

edited

Loading