more POD cleanup for Value/Matrices.pm#1197
Conversation
somiaj
left a comment
There was a problem hiding this comment.
Skimmed over the changes, and overall looks good.
Should the links be updated to point to the new location for the wiki?
I'm not caught up on this. Where is the new location? There are local relative links here that just will go to a different POD page. And there are links here to the forums at webwork.maa.org/moodle/mod/forum. Which kind of thing do you mean? |
|
It is the |
|
Don't change the links at this point. The actual details of the move are not certain yet. |
|
The new wiki location is not in production yet. It will live at the address you quoted, but right now that has an old copy of the wiki. Until we officially migrate please continue to make any wiki updates on the webwork.maa.org site. The intention is to have webwork.maa.org point to the new server, so for the time being existing links shouldn't break. We'll set up redirects to try to get people to use the new URLs once they're ready to go. |
|
Two approvals now, merge this? Phase 3 will be to review the existing methods and look for ways to improve them (either more efficient or more flexible). |
This continues #1188, with POD changes (and minor code changes like
foreachtofor) that are largely the same as in #1076. For that reason I credited the commit to @pstaabp (hope that's OK). The diff between this branch and the #1076 branch should be a bit smaller than between #1076 and develop, only showing the new additions in #1076 plus some consequences of small things cleaned up here or in #1188.To review this, you should just confirm that it is moving or lightly editing POD. And that any code changes are trivial/minor.
The next phase for this would be enhancing or changing existing methods, if we want to do any of that. For example enhancements like letting the
rowmethod take multiple arguments. And changes like treating 1D Matrix objects as column vectors instead of row vectors (regarding their presentation and interactions with 2D Matrix objects).