Skip to content

github: add openwrt-bot-worker as formality check#8772

Open
BKPepe wants to merge 1 commit into
openwrt:masterfrom
BKPepe:use-openwrt-webhook
Open

github: add openwrt-bot-worker as formality check#8772
BKPepe wants to merge 1 commit into
openwrt:masterfrom
BKPepe:use-openwrt-webhook

Conversation

@BKPepe

@BKPepe BKPepe commented Jul 1, 2026

Copy link
Copy Markdown
Member

github: add webhook formality check

Replace the external formality check GitHub Action with a lightweight
webhook managed by the openwrt-bot-worker engine.

Using a webhook instead of a heavy GitHub Action workflow is much more
suitable for quick formality checks. GitHub Actions are constrained by
concurrency limits across repositories, often causing long delays. In
contrast, the webhook validates commits near-instantly.

The validation rules are configured via .github/formalities.json. Since
verifying PKG_VERSION, PKG_RELEASE, and mandatory release notes are
not relevant for the LuCI repository (unlike packages), these checks are
disabled.

Additionally, the formality check is now a hard requirement. The build
workflow will only run once the formality check passes, saving runner
resources.

Requires:
#8757 - based on top of this branch
#8759
openwrt/actions-shared-workflows#126

Copilot AI review requested due to automatic review settings July 1, 2026 18:49
@BKPepe BKPepe changed the title github: add openwrt-bot-wopenwrt-bot-worker as formality check github: add openwrt-bot-worker as formality check Jul 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the repository’s GitHub Actions–based “formalities” check with an external webhook-driven FormalityCheck, and gates the build workflow on that check completing successfully to avoid wasting CI capacity.

Changes:

  • Remove the formal.yml workflow that previously ran HyperStickler for commit/message formalities.
  • Update build.yml to wait for the FormalityCheck / Git & Commits check-run before running the reusable multi-arch build workflow.
  • Add .github/formalities.json to configure the webhook’s formality validation rules (disabling package-specific checks not relevant to LuCI).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/formal.yml Removes the old HyperStickler-based “formalities” GitHub Actions workflow.
.github/workflows/build.yml Adds a gating job that waits for the FormalityCheck check-run, then triggers the shared build workflow.
.github/formalities.json Introduces the webhook configuration for commit/PR formalities checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build.yml
@BKPepe BKPepe force-pushed the use-openwrt-webhook branch 2 times, most recently from 2a891e3 to 307b19d Compare July 1, 2026 19:12

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 new commits; one minor nit inline. Both commit messages match their diffs. The .github/formalities.json config aligns with the PR description (package-specific checks disabled), and check_openwrt_meta: ["PKG_MAINTAINER", "PKG_LICENSE"] matches existing LuCI practice (95/100 and 99/100 of luci-app-* Makefiles set those, respectively). Note: I could not verify the lewagon/wait-on-check-action@v1.8.0 tag or the reusable-workflow/webhook behavior from here — those depend on external repos (actions-shared-workflows PR #126, the openwrt-bot-worker check name FormalityCheck / Git & Commits) that aren't in scope for this review.


Generated by Claude Code

Comment thread .github/workflows/build.yml Outdated
@BKPepe BKPepe force-pushed the use-openwrt-webhook branch from 307b19d to cc22b37 Compare July 2, 2026 08:30

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found. The only change since the previous review is the removal of a trailing blank line at the end of .github/workflows/build.yml; the commit message still matches its contents.


Generated by Claude Code

@BKPepe BKPepe force-pushed the use-openwrt-webhook branch 2 times, most recently from 6d16b37 to 6fdacb3 Compare July 7, 2026 08:59
Replace the external formality check GitHub Action with a lightweight
webhook managed by the openwrt-bot-worker engine.

Using a webhook instead of a heavy GitHub Action workflow is much more
suitable for quick formality checks. GitHub Actions are constrained by
concurrency limits across repositories, often causing long delays. In
contrast, the webhook validates commits near-instantly.

The validation rules are configured via `.github/formalities.json`. Since
verifying `PKG_VERSION`, `PKG_RELEASE`, and mandatory release notes are
not relevant for the LuCI repository (unlike packages), these checks are
disabled.

Additionally, the formality check is now a hard requirement. The build
workflow will only run once the formality check passes, saving runner
resources.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
@BKPepe BKPepe force-pushed the use-openwrt-webhook branch from 6fdacb3 to 5606383 Compare July 7, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants